You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Dan Dumont <dd...@us.ibm.com> on 2012/02/28 21:20:41 UTC
Review Request: Pass more information into some lifecycle event listeners.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4090/
-----------------------------------------------------------
Review request for shindig, Ryan Baxter and Stanton Sievers.
Summary
-------
I recently had need to pass more information (gadget site id) into the ON_RENDER lifecycle event. In order to not break existing impl by changing the current value passed, I wanted to add it as a new param so that required some additional changes.
I plan on committing this after Ryan and Stanton review it. It's still a pretty small patch but it's larger than the 1-2 lines I was hoping for, so I wanted something here for informational purposes.
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site/site_holder.js 1294801
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1294801
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1294801
Diff: https://reviews.apache.org/r/4090/diff
Testing
-------
updated tests.
Thanks,
Dan
Re: Review Request: Pass more information into some lifecycle event
listeners.
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4090/#review5457
-----------------------------------------------------------
Ship it!
Committed r1295130
- Dan
On 2012-02-29 14:30:11, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4090/
> -----------------------------------------------------------
>
> (Updated 2012-02-29 14:30:11)
>
>
> Review request for shindig, Ryan Baxter and Stanton Sievers.
>
>
> Summary
> -------
>
> I recently had need to pass more information (gadget site id) into the ON_RENDER lifecycle event. In order to not break existing impl by changing the current value passed, I wanted to add it as a new param so that required some additional changes.
>
> I plan on committing this after Ryan and Stanton review it. It's still a pretty small patch but it's larger than the 1-2 lines I was hoping for, so I wanted something here for informational purposes.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site/site_holder.js 1295128
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1295128
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1295128
>
> Diff: https://reviews.apache.org/r/4090/diff
>
>
> Testing
> -------
>
> updated tests.
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Pass more information into some lifecycle event
listeners.
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4090/
-----------------------------------------------------------
(Updated 2012-02-29 14:30:11.440540)
Review request for shindig, Ryan Baxter and Stanton Sievers.
Changes
-------
Updated jsdoc.
Summary
-------
I recently had need to pass more information (gadget site id) into the ON_RENDER lifecycle event. In order to not break existing impl by changing the current value passed, I wanted to add it as a new param so that required some additional changes.
I plan on committing this after Ryan and Stanton review it. It's still a pretty small patch but it's larger than the 1-2 lines I was hoping for, so I wanted something here for informational purposes.
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site/site_holder.js 1295128
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1295128
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1295128
Diff: https://reviews.apache.org/r/4090/diff
Testing
-------
updated tests.
Thanks,
Dan
Re: Review Request: Pass more information into some lifecycle event
listeners.
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4090/#review5409
-----------------------------------------------------------
Ship it!
LGTM
- Stanton
On 2012-02-28 20:20:41, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4090/
> -----------------------------------------------------------
>
> (Updated 2012-02-28 20:20:41)
>
>
> Review request for shindig, Ryan Baxter and Stanton Sievers.
>
>
> Summary
> -------
>
> I recently had need to pass more information (gadget site id) into the ON_RENDER lifecycle event. In order to not break existing impl by changing the current value passed, I wanted to add it as a new param so that required some additional changes.
>
> I plan on committing this after Ryan and Stanton review it. It's still a pretty small patch but it's larger than the 1-2 lines I was hoping for, so I wanted something here for informational purposes.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site/site_holder.js 1294801
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1294801
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1294801
>
> Diff: https://reviews.apache.org/r/4090/diff
>
>
> Testing
> -------
>
> updated tests.
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Pass more information into some lifecycle event
listeners.
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4090/#review5412
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
<https://reviews.apache.org/r/4090/#comment11802>
Update the JS doc
- Ryan
On 2012-02-28 20:20:41, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4090/
> -----------------------------------------------------------
>
> (Updated 2012-02-28 20:20:41)
>
>
> Review request for shindig, Ryan Baxter and Stanton Sievers.
>
>
> Summary
> -------
>
> I recently had need to pass more information (gadget site id) into the ON_RENDER lifecycle event. In order to not break existing impl by changing the current value passed, I wanted to add it as a new param so that required some additional changes.
>
> I plan on committing this after Ryan and Stanton review it. It's still a pretty small patch but it's larger than the 1-2 lines I was hoping for, so I wanted something here for informational purposes.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site/site_holder.js 1294801
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1294801
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1294801
>
> Diff: https://reviews.apache.org/r/4090/diff
>
>
> Testing
> -------
>
> updated tests.
>
>
> Thanks,
>
> Dan
>
>