[GitHub] [spark] zhengruifeng commented on a diff in pull request #42388: [SPARK-43618][SPARK-43658][CONNECT][PS][TESTS] Enabling more tests

["zhengruifeng (via GitHub)" <gi...@apache.org>]

zhengruifeng commented on code in PR #42388:
URL: https://github.com/apache/spark/pull/42388#discussion_r1286597113


##########
python/pyspark/pandas/tests/computation/test_compute.py:
##########
@@ -101,16 +101,9 @@ def test_mode(self):
         with self.assertRaises(ValueError):
             psdf.mode(axis=2)
 
-        def f(index, iterator):

Review Comment:
   IIRC, this one is by design. Using the specific partitioning to test a mode bug, see https://github.com/apache/spark/pull/38385/files
   
   but I'm fine to remove this one now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org