You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "raphinesse (GitHub)" <gi...@apache.org> on 2018/08/26 12:43:11 UTC

[GitHub] [cordova-lib] raphinesse opened pull request #649: Misc spec fixes/cleanup

Mostly revolving around ESLint stuff. This is a diverse assortment, but I would like to avoid to create a PR for every one of these changes. If some are controversial, I'd be happy to pull them out for now, though.

[ Full content available at: https://github.com/apache/cordova-lib/pull/649 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [cordova-lib] codecov-io commented on issue #649: Misc spec fixes/cleanup

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=h1) Report
> Merging [#649](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/b77f5aeeab61e6d0a0691cfb587af298861dc215?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/cordova-lib/pull/649/graphs/tree.svg?width=650&token=KwBjKMXLqA&height=150&src=pr)](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master     #649   +/-   ##
=======================================
  Coverage   80.79%   80.79%           
=======================================
  Files          57       57           
  Lines        3015     3015           
=======================================
  Hits         2436     2436           
  Misses        579      579
```


| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cordova-lib.js](https://codecov.io/gh/apache/cordova-lib/pull/649/diff?src=pr&el=tree#diff-Y29yZG92YS1saWIuanM=) | `50% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=footer). Last update [b77f5ae...6eed5ae](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/cordova-lib/pull/649 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [cordova-lib] codecov-io commented on issue #649: Misc spec fixes/cleanup

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=h1) Report
> Merging [#649](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/b77f5aeeab61e6d0a0691cfb587af298861dc215?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/cordova-lib/pull/649/graphs/tree.svg?width=650&token=KwBjKMXLqA&height=150&src=pr)](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master     #649   +/-   ##
=======================================
  Coverage   80.79%   80.79%           
=======================================
  Files          57       57           
  Lines        3015     3015           
=======================================
  Hits         2436     2436           
  Misses        579      579
```


| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cordova-lib.js](https://codecov.io/gh/apache/cordova-lib/pull/649/diff?src=pr&el=tree#diff-Y29yZG92YS1saWIuanM=) | `50% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=footer). Last update [b77f5ae...6eed5ae](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/cordova-lib/pull/649 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [cordova-lib] codecov-io commented on issue #649: Misc spec fixes/cleanup

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=h1) Report
> Merging [#649](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/b77f5aeeab61e6d0a0691cfb587af298861dc215?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/cordova-lib/pull/649/graphs/tree.svg?width=650&token=KwBjKMXLqA&height=150&src=pr)](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master     #649   +/-   ##
=======================================
  Coverage   80.79%   80.79%           
=======================================
  Files          57       57           
  Lines        3015     3015           
=======================================
  Hits         2436     2436           
  Misses        579      579
```


| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cordova-lib.js](https://codecov.io/gh/apache/cordova-lib/pull/649/diff?src=pr&el=tree#diff-Y29yZG92YS1saWIuanM=) | `50% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=footer). Last update [b77f5ae...6183f68](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/cordova-lib/pull/649 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [cordova-lib] raphinesse closed pull request #649: Misc spec fixes/cleanup

Posted by "raphinesse (GitHub)" <gi...@apache.org>.
[ pull request closed by raphinesse ]

[ Full content available at: https://github.com/apache/cordova-lib/pull/649 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [cordova-lib] codecov-io commented on issue #649: Misc spec fixes/cleanup

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=h1) Report
> Merging [#649](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/b77f5aeeab61e6d0a0691cfb587af298861dc215?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/cordova-lib/pull/649/graphs/tree.svg?width=650&token=KwBjKMXLqA&height=150&src=pr)](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master     #649   +/-   ##
=======================================
  Coverage   80.79%   80.79%           
=======================================
  Files          57       57           
  Lines        3015     3015           
=======================================
  Hits         2436     2436           
  Misses        579      579
```


| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cordova-lib.js](https://codecov.io/gh/apache/cordova-lib/pull/649/diff?src=pr&el=tree#diff-Y29yZG92YS1saWIuanM=) | `50% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=footer). Last update [b77f5ae...6183f68](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/cordova-lib/pull/649 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [cordova-lib] raphinesse closed pull request #649: Misc spec fixes/cleanup

Posted by "raphinesse (GitHub)" <gi...@apache.org>.
[ pull request closed by raphinesse ]

[ Full content available at: https://github.com/apache/cordova-lib/pull/649 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [cordova-lib] codecov-io commented on issue #649: Misc spec fixes/cleanup

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=h1) Report
> Merging [#649](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/b77f5aeeab61e6d0a0691cfb587af298861dc215?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/cordova-lib/pull/649/graphs/tree.svg?width=650&token=KwBjKMXLqA&height=150&src=pr)](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master     #649   +/-   ##
=======================================
  Coverage   80.79%   80.79%           
=======================================
  Files          57       57           
  Lines        3015     3015           
=======================================
  Hits         2436     2436           
  Misses        579      579
```


| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cordova-lib.js](https://codecov.io/gh/apache/cordova-lib/pull/649/diff?src=pr&el=tree#diff-Y29yZG92YS1saWIuanM=) | `50% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=footer). Last update [b77f5ae...6183f68](https://codecov.io/gh/apache/cordova-lib/pull/649?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/cordova-lib/pull/649 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org