[GitHub] andretadeu commented on issue #2: [MJMOD-8] NullPointerException on create

[GitBox <gi...@apache.org>]

andretadeu commented on issue #2: [MJMOD-8] NullPointerException on create
URL: https://github.com/apache/maven-jmod-plugin/pull/2#issuecomment-446694864
 
 
   Of course, I have two working examples:
   
   The first one I created a multi-module Maven project where I generated both JAR and JMOD files in each project that contains Java source code with module-info.java, which is in https://github.com/andretadeu/maven-jigsaw-examples/tree/master/multi-modules-jmod-jlink. The second project is the same project in the issue, but with fixes, where there is a separated project to generate the JMOD from JAR, which is in https://github.com/andretadeu/npe-on-alpha-2.
   
   Thinking about the approach of each module generating only one artifact, the second example seems more suitable, in my humble view. What do you think of these examples?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services