You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Noorul Islam K M <no...@collab.net> on 2011/02/19 04:28:55 UTC
[PATCH] Fix a bug introduced in r1071025.
Without the patch I get Segmentation fault when I pass unknown command
to svnadmin command.
Log
[[[
Fix a bug introduced in r1071025.
* subversion/svnadmin/main.c
(parse_args): Handle NULL argument.
Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
]]]
Re: [PATCH] Fix a bug introduced in r1071025.
Posted by Stefan Sperling <st...@elego.de>.
On Sun, Feb 27, 2011 at 11:40:47PM +1100, Gavin Beau Baumanis wrote:
> Thanks Stefan,
> I will remove it from my list.
>
Why does this always remind of Earl Hickey? :)
Re: [PATCH] Fix a bug introduced in r1071025.
Posted by Gavin Beau Baumanis <ga...@thespidernet.com>.
Thanks Stefan,
I will remove it from my list.
On 27/02/2011, at 11:18 PM, Stefan Sperling wrote:
> On Sun, Feb 27, 2011 at 10:55:55PM +1100, Gavin Beau Baumanis wrote:
>> Ping. This patch submission has received no comments.
>
> Thanks Gavin. This has already been committed (r1072242).
>
>>
>> On 19/02/2011, at 2:28 PM, Noorul Islam K M wrote:
>>
>>>
>>> Without the patch I get Segmentation fault when I pass unknown command
>>> to svnadmin command.
>>>
>>> Log
>>>
>>> [[[
>>> Fix a bug introduced in r1071025.
>>>
>>> * subversion/svnadmin/main.c
>>> (parse_args): Handle NULL argument.
>>>
>>> Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
>>> ]]]
>>>
>>> Index: subversion/svnadmin/main.c
>>> ===================================================================
>>> --- subversion/svnadmin/main.c (revision 1072234)
>>> +++ subversion/svnadmin/main.c (working copy)
>>> @@ -549,7 +549,7 @@
>>> int max_expected,
>>> apr_pool_t *pool)
>>> {
>>> - int num_args = os->argc - os->ind;
>>> + int num_args = os ? (os->argc - os->ind) : 0;
>>>
>>> if (min_expected || max_expected)
>>> SVN_ERR_ASSERT(args);
Re: [PATCH] Fix a bug introduced in r1071025.
Posted by Stefan Sperling <st...@elego.de>.
On Sun, Feb 27, 2011 at 10:55:55PM +1100, Gavin Beau Baumanis wrote:
> Ping. This patch submission has received no comments.
Thanks Gavin. This has already been committed (r1072242).
>
> On 19/02/2011, at 2:28 PM, Noorul Islam K M wrote:
>
> >
> > Without the patch I get Segmentation fault when I pass unknown command
> > to svnadmin command.
> >
> > Log
> >
> > [[[
> > Fix a bug introduced in r1071025.
> >
> > * subversion/svnadmin/main.c
> > (parse_args): Handle NULL argument.
> >
> > Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
> > ]]]
> >
> > Index: subversion/svnadmin/main.c
> > ===================================================================
> > --- subversion/svnadmin/main.c (revision 1072234)
> > +++ subversion/svnadmin/main.c (working copy)
> > @@ -549,7 +549,7 @@
> > int max_expected,
> > apr_pool_t *pool)
> > {
> > - int num_args = os->argc - os->ind;
> > + int num_args = os ? (os->argc - os->ind) : 0;
> >
> > if (min_expected || max_expected)
> > SVN_ERR_ASSERT(args);
Re: [PATCH] Fix a bug introduced in r1071025.
Posted by Gavin Beau Baumanis <ga...@thespidernet.com>.
Ping. This patch submission has received no comments.
On 19/02/2011, at 2:28 PM, Noorul Islam K M wrote:
>
> Without the patch I get Segmentation fault when I pass unknown command
> to svnadmin command.
>
> Log
>
> [[[
> Fix a bug introduced in r1071025.
>
> * subversion/svnadmin/main.c
> (parse_args): Handle NULL argument.
>
> Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
> ]]]
>
> Index: subversion/svnadmin/main.c
> ===================================================================
> --- subversion/svnadmin/main.c (revision 1072234)
> +++ subversion/svnadmin/main.c (working copy)
> @@ -549,7 +549,7 @@
> int max_expected,
> apr_pool_t *pool)
> {
> - int num_args = os->argc - os->ind;
> + int num_args = os ? (os->argc - os->ind) : 0;
>
> if (min_expected || max_expected)
> SVN_ERR_ASSERT(args);