[GitHub] [hbase] Joseph295 commented on a change in pull request #1675: HBASE-24341 The region should be removed from ConfigurationManager as…

[GitBox <gi...@apache.org>]

Joseph295 commented on a change in pull request #1675:
URL: https://github.com/apache/hbase/pull/1675#discussion_r422624585



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/conf/ConfigurationManager.java
##########
@@ -137,4 +138,14 @@ public int getNumObservers() {
       return configurationObservers.size();
     }
   }
+
+  /**
+   * @return the observers
+   */
+  @VisibleForTesting
+  public Set<ConfigurationObserver> getConfigurationObservers() {

Review comment:
       Good point! The synchronization here doesn't prevent multithread-access afterwards, right? Or we may not consider the multi-thread access cos it is used in unittest only? What do you think about it, Anoops ? I added a synchronized method which returns a boolean for now, looking forward to your opinion.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org