You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Matthew Jacobs (Code Review)" <ge...@cloudera.org> on 2017/03/01 21:49:29 UTC
[native-toolchain-CR] IMPALA-5002: Associate toolchain build scripts/flags with built packages
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6210
Change subject: IMPALA-5002: Associate toolchain build scripts/flags with built packages
......................................................................
IMPALA-5002: Associate toolchain build scripts/flags with built packages
Adds the current git hash of the native-toolchain so that
the build scripts (including things like compilation/linker
flags) can be associated with the packages later. Before
this change, it was difficult to know if the way in which a
package was built changed by only looking at the packages
downloaded by Impala.
Change-Id: Ida6f1eee0c20de7fbfdbb716e5c7ac8686b558b6
---
M functions.sh
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/10/6210/1
--
To view, visit http://gerrit.cloudera.org:8080/6210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida6f1eee0c20de7fbfdbb716e5c7ac8686b558b6
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
[native-toolchain-CR] IMPALA-5002: Associate toolchain build scripts/flags with built packages
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5002: Associate toolchain build scripts/flags with built packages
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Seems like a good thing to track
http://gerrit.cloudera.org:8080/#/c/6210/2/functions.sh
File functions.sh:
Line 351: git rev-parse HEAD > ${BUILD_DIR}/${PACKAGE_STRING}${PATCH_VERSION}/toolchain-build-hash.txt
Long line
--
To view, visit http://gerrit.cloudera.org:8080/6210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida6f1eee0c20de7fbfdbb716e5c7ac8686b558b6
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-5002: Associate toolchain build scripts/flags with built packages
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has uploaded a new patch set (#2).
Change subject: IMPALA-5002: Associate toolchain build scripts/flags with built packages
......................................................................
IMPALA-5002: Associate toolchain build scripts/flags with built packages
Adds the current git hash of the native-toolchain so that
the build scripts (including things like compilation/linker
flags) can be associated with the packages later. Before
this change, it was difficult to know if the way in which a
package was built changed by only looking at the packages
downloaded by Impala.
Change-Id: Ida6f1eee0c20de7fbfdbb716e5c7ac8686b558b6
---
M functions.sh
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/10/6210/2
--
To view, visit http://gerrit.cloudera.org:8080/6210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida6f1eee0c20de7fbfdbb716e5c7ac8686b558b6
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
[native-toolchain-CR] IMPALA-5002: Associate toolchain build scripts/flags with built packages
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5002: Associate toolchain build scripts/flags with built packages
......................................................................
Patch Set 3: Code-Review+2 Verified+1
carry +2
--
To view, visit http://gerrit.cloudera.org:8080/6210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida6f1eee0c20de7fbfdbb716e5c7ac8686b558b6
Gerrit-PatchSet: 3
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-5002: Associate toolchain build scripts/flags with built packages
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6210
to look at the new patch set (#3).
Change subject: IMPALA-5002: Associate toolchain build scripts/flags with built packages
......................................................................
IMPALA-5002: Associate toolchain build scripts/flags with built packages
Adds the current git hash of the native-toolchain so that
the build scripts (including things like compilation/linker
flags) can be associated with the packages later. Before
this change, it was difficult to know if the way in which a
package was built changed by only looking at the packages
downloaded by Impala.
Change-Id: Ida6f1eee0c20de7fbfdbb716e5c7ac8686b558b6
---
M functions.sh
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/10/6210/3
--
To view, visit http://gerrit.cloudera.org:8080/6210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida6f1eee0c20de7fbfdbb716e5c7ac8686b558b6
Gerrit-PatchSet: 3
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] IMPALA-5002: Associate toolchain build scripts/flags with built packages
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has submitted this change and it was merged.
Change subject: IMPALA-5002: Associate toolchain build scripts/flags with built packages
......................................................................
IMPALA-5002: Associate toolchain build scripts/flags with built packages
Adds the current git hash of the native-toolchain so that
the build scripts (including things like compilation/linker
flags) can be associated with the packages later. Before
this change, it was difficult to know if the way in which a
package was built changed by only looking at the packages
downloaded by Impala.
Change-Id: Ida6f1eee0c20de7fbfdbb716e5c7ac8686b558b6
---
M functions.sh
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Matthew Jacobs: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/6210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida6f1eee0c20de7fbfdbb716e5c7ac8686b558b6
Gerrit-PatchSet: 3
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>