[jira] [Commented] (GEODE-5197) synchronize the adding and removal of cache service profiles while reindexing

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-5197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570908#comment-16570908 ] 

ASF subversion and git services commented on GEODE-5197:
--------------------------------------------------------

Commit 0bad03af681bb611f432009354baf3816e96f101 in geode's branch refs/heads/develop from nabarun
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0bad03a ]

GEODE-5197: Synchronized update cache service profile in lucene.

	* new lock created for updating the region's cache service profile
	* synchronized the addition / validation / removal of LuceneIndexCreationProfile in the data region.


> synchronize the adding and removal of cache service profiles while reindexing
> -----------------------------------------------------------------------------
>
>                 Key: GEODE-5197
>                 URL: https://issues.apache.org/jira/browse/GEODE-5197
>             Project: Geode
>          Issue Type: Sub-task
>          Components: lucene
>            Reporter: nabarun
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> As a gemfire developer, while creating a lucene index on the data region the addition/verification/[or removal] to the region's cache service profile should not be affected by concurrent index creation.
> The below code needs to be synchronized
> {code:java}
> private void createIndexOnExistingRegion(PartitionedRegion region, String indexName,
>       String regionPath, String[] fields, Analyzer analyzer, Map<String, Analyzer> fieldAnalyzers,
>       LuceneSerializer serializer) {
>     validateRegionAttributes(region.getAttributes());
>     LuceneIndexCreationProfile luceneIndexCreationProfile = new LuceneIndexCreationProfile(
>         indexName, regionPath, fields, analyzer, fieldAnalyzers, serializer);
>     region.addCacheServiceProfile(luceneIndexCreationProfile);
>     try {
>       validateLuceneIndexProfile(region);
>     } catch (Exception e) {
>       region.removeCacheServiceProfile(luceneIndexCreationProfile.getId());
>       throw new UnsupportedOperationException(
>           LocalizedStrings.LuceneIndexCreation_INDEX_CANNOT_BE_CREATED_DUE_TO_PROFILE_VIOLATION
>               .toString(indexName),
>           e);
>     }
>     String aeqId = LuceneServiceImpl.getUniqueIndexName(indexName, regionPath);
>     region.updatePRConfigWithNewGatewaySender(aeqId);
>     LuceneIndexImpl luceneIndex = beforeDataRegionCreated(indexName, regionPath,
>         region.getAttributes(), analyzer, fieldAnalyzers, aeqId, serializer, fields);
>     afterDataRegionCreated(luceneIndex);
>     createLuceneIndexOnDataRegion(region, luceneIndex);
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)