[GitHub] spark pull request: [SPARK-4666] Improve YarnAllocator's parsing o...

[ryan-williams <gi...@git.apache.org>]

Github user ryan-williams commented on the pull request:

    https://github.com/apache/spark/pull/3525#issuecomment-73625367
  
    OK, this is ready to go again. Changes:
    * removed SPARK-4665 from the title and closed that JIRA
    * in the process of rebasing this change I found myself wanting "MB" suffixes on various `Int` variables that represent numbers of megabytes; I've included several commits here that perform such renames, but they're separate and easy to remove from this PR if that's controversial
    * I made `Utils.getMaxResultSize(SparkConf)` a method of `SparkConf` instead.
    * I cleaned up the semantics around which `Utils` and `SparkConf` methods assume `Int`s to represent numbers of megabytes, vs. ones that are generic across memory-size orders-of-magnitude.
    
    Let me know what you think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org