You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@commonsrdf.apache.org by Benedikt Ritter <br...@apache.org> on 2015/03/30 12:50:36 UTC

@author tags

Hi,

at the Apache Commons project, we've decided to attribute authors of the
code in the developers section of pom.xml. While browsing the code, I found
four classes with @author tag:

- simple/src/test/java/org/apache/commons/rdf/simple/BlankNodeImplTest.java
- simple/src/test/java/org/apache/commons/rdf/simple/TypesTest.java
- api/src/test/java/org/apache/commons/rdf/api/AbstractBlankNodeTest.java
- simple/src/main/java/org/apache/commons/rdf/simple/Types.java

Would it be a problem for the Commons RDF community to move this
attributions to pom.xml?

Thank you!
Benedikt

-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Re: @author tags

Posted by Gary Gregory <ga...@gmail.com>.

On Mon, Mar 30, 2015 at 3:50 AM, Benedikt Ritter <br...@apache.org> wrote:

> Hi,
>
> at the Apache Commons project, we've decided to attribute authors of the
> code in the developers section of pom.xml. While browsing the code, I found
> four classes with @author tag:
>
> - simple/src/test/java/org/apache/commons/rdf/simple/BlankNodeImplTest.java
> - simple/src/test/java/org/apache/commons/rdf/simple/TypesTest.java
> - api/src/test/java/org/apache/commons/rdf/api/AbstractBlankNodeTest.java
> - simple/src/main/java/org/apache/commons/rdf/simple/Types.java
>
> Would it be a problem for the Commons RDF community to move this
> attributions to pom.xml?
>

+1

Gary

>
> Thank you!
> Benedikt
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>



-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: @author tags

Posted by Sergio Fernández <se...@redlink.co>.

+0, both ways work for me, but if Commons has a rule about that let's
follow it


Sergio Fernández
Partner Technology Manager
Redlink GmbH
m: +43 6602747925
e: sergio.fernandez@redlink.co
w: http://redlink.co

On Mon, Mar 30, 2015 at 11:33 PM, Peter Ansell <an...@gmail.com>
wrote:

> I like @author tags in general, but have no qualms about moving them to
> pom.xml.
>
> On 31 March 2015 at 00:34, Andy Seaborne <an...@apache.org> wrote:
> > On 30/03/15 11:50, Benedikt Ritter wrote:
> >>
> >> Hi,
> >>
> >> at the Apache Commons project, we've decided to attribute authors of the
> >> code in the developers section of pom.xml. While browsing the code, I
> >> found
> >> four classes with @author tag:
> >>
> >> -
> >>
> simple/src/test/java/org/apache/commons/rdf/simple/BlankNodeImplTest.java
> >> - simple/src/test/java/org/apache/commons/rdf/simple/TypesTest.java
> >> -
> api/src/test/java/org/apache/commons/rdf/api/AbstractBlankNodeTest.java
> >> - simple/src/main/java/org/apache/commons/rdf/simple/Types.java
> >>
> >> Would it be a problem for the Commons RDF community to move this
> >> attributions to pom.xml?
> >
> >
> > Not for me - attribution on specific files can put people off so I'm not
> in
> > favour of @author.
> >
> > The POM, or a separate file, is a good place to recognize contribution.
> >
> >         Andy
> >
> >>
> >> Thank you!
> >> Benedikt
> >>
> >
>

Re: @author tags

Posted by Peter Ansell <an...@gmail.com>.

I like @author tags in general, but have no qualms about moving them to pom.xml.

On 31 March 2015 at 00:34, Andy Seaborne <an...@apache.org> wrote:
> On 30/03/15 11:50, Benedikt Ritter wrote:
>>
>> Hi,
>>
>> at the Apache Commons project, we've decided to attribute authors of the
>> code in the developers section of pom.xml. While browsing the code, I
>> found
>> four classes with @author tag:
>>
>> -
>> simple/src/test/java/org/apache/commons/rdf/simple/BlankNodeImplTest.java
>> - simple/src/test/java/org/apache/commons/rdf/simple/TypesTest.java
>> - api/src/test/java/org/apache/commons/rdf/api/AbstractBlankNodeTest.java
>> - simple/src/main/java/org/apache/commons/rdf/simple/Types.java
>>
>> Would it be a problem for the Commons RDF community to move this
>> attributions to pom.xml?
>
>
> Not for me - attribution on specific files can put people off so I'm not in
> favour of @author.
>
> The POM, or a separate file, is a good place to recognize contribution.
>
>         Andy
>
>>
>> Thank you!
>> Benedikt
>>
>

Re: @author tags

Posted by Stian Soiland-Reyes <st...@apache.org>.

+1 to remove @author and simply keep the committers in the pom.
On 30 Mar 2015 14:34, "Andy Seaborne" <an...@apache.org> wrote:

> On 30/03/15 11:50, Benedikt Ritter wrote:
>
>> Hi,
>>
>> at the Apache Commons project, we've decided to attribute authors of the
>> code in the developers section of pom.xml. While browsing the code, I
>> found
>> four classes with @author tag:
>>
>> - simple/src/test/java/org/apache/commons/rdf/simple/
>> BlankNodeImplTest.java
>> - simple/src/test/java/org/apache/commons/rdf/simple/TypesTest.java
>> - api/src/test/java/org/apache/commons/rdf/api/AbstractBlankNodeTest.java
>> - simple/src/main/java/org/apache/commons/rdf/simple/Types.java
>>
>> Would it be a problem for the Commons RDF community to move this
>> attributions to pom.xml?
>>
>
> Not for me - attribution on specific files can put people off so I'm not
> in favour of @author.
>
> The POM, or a separate file, is a good place to recognize contribution.
>
>         Andy
>
>
>> Thank you!
>> Benedikt
>>
>>
>

Re: @author tags

Posted by Andy Seaborne <an...@apache.org>.

On 30/03/15 11:50, Benedikt Ritter wrote:
> Hi,
>
> at the Apache Commons project, we've decided to attribute authors of the
> code in the developers section of pom.xml. While browsing the code, I found
> four classes with @author tag:
>
> - simple/src/test/java/org/apache/commons/rdf/simple/BlankNodeImplTest.java
> - simple/src/test/java/org/apache/commons/rdf/simple/TypesTest.java
> - api/src/test/java/org/apache/commons/rdf/api/AbstractBlankNodeTest.java
> - simple/src/main/java/org/apache/commons/rdf/simple/Types.java
>
> Would it be a problem for the Commons RDF community to move this
> attributions to pom.xml?

Not for me - attribution on specific files can put people off so I'm not 
in favour of @author.

The POM, or a separate file, is a good place to recognize contribution.

	Andy

>
> Thank you!
> Benedikt
>