You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/11 15:13:35 UTC
[GitHub] [superset] dpgaspar opened a new pull request #13578: fix: handle datasource injected security exception
dpgaspar opened a new pull request #13578:
URL: https://github.com/apache/superset/pull/13578
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (a4c1cb3) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `6.45%`.
> The diff coverage is `57.00%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 71.08% -6.46%
==========================================
Files 904 827 -77
Lines 45986 41450 -4536
Branches 5552 4300 -1252
==========================================
- Hits 35657 29464 -6193
- Misses 10195 11986 +1791
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.75% <23.56%> (-0.45%)` | :arrow_down: |
| hive | `80.08% <76.38%> (-0.05%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.68% <76.38%> (-0.32%)` | :arrow_down: |
| sqlite | `80.05% <74.53%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `0.00% <0.00%> (-38.89%)` | :arrow_down: |
| [...s/controls/MetricControl/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY0RlZmluaXRpb25WYWx1ZS5qc3g=) | `93.33% <ø> (-0.79%)` | :arrow_down: |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.78% <ø> (ø)` | |
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.35% <0.00%> (-9.81%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndMetricSelect.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZE1ldHJpY1NlbGVjdC50c3g=) | `4.42% <4.42%> (ø)` | |
| ... and [523 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...1835f4f](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (d3b740f) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `6.46%`.
> The diff coverage is `56.80%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 71.07% -6.47%
==========================================
Files 904 827 -77
Lines 45986 41449 -4537
Branches 5552 4300 -1252
==========================================
- Hits 35657 29459 -6198
- Misses 10195 11990 +1795
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <23.56%> (-0.47%)` | :arrow_down: |
| hive | `80.08% <76.20%> (-0.05%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.68% <76.20%> (-0.32%)` | :arrow_down: |
| sqlite | `80.05% <74.34%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `0.00% <0.00%> (-38.89%)` | :arrow_down: |
| [...s/controls/MetricControl/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY0RlZmluaXRpb25WYWx1ZS5qc3g=) | `93.33% <ø> (-0.79%)` | :arrow_down: |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.78% <ø> (ø)` | |
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.35% <0.00%> (-9.81%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndMetricSelect.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZE1ldHJpY1NlbGVjdC50c3g=) | `4.42% <4.42%> (ø)` | |
| ... and [524 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...1835f4f](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (3d9ac8e) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `6.61%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 70.92% -6.62%
==========================================
Files 904 827 -77
Lines 45986 41421 -4565
Branches 5552 4300 -1252
==========================================
- Hits 35657 29377 -6280
- Misses 10195 12044 +1849
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <ø> (-0.48%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.38% <100.00%> (-0.07%)` | :arrow_down: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.44% <100.00%> (-0.56%)` | :arrow_down: |
| sqlite | `80.05% <100.00%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.12% <100.00%> (-1.87%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.62% <100.00%> (+0.07%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [511 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...3d9ac8e](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (11021d5) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `6.41%`.
> The diff coverage is `57.51%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 71.12% -6.42%
==========================================
Files 904 827 -77
Lines 45986 41422 -4564
Branches 5552 4300 -1252
==========================================
- Hits 35657 29461 -6196
- Misses 10195 11961 +1766
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.74% <23.56%> (-0.47%)` | :arrow_down: |
| hive | `80.06% <76.95%> (-0.07%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `80.38% <75.46%> (-0.07%)` | :arrow_down: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.77% <77.32%> (-0.23%)` | :arrow_down: |
| sqlite | `80.05% <75.09%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `0.00% <0.00%> (-38.89%)` | :arrow_down: |
| [...s/controls/MetricControl/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY0RlZmluaXRpb25WYWx1ZS5qc3g=) | `93.33% <ø> (-0.79%)` | :arrow_down: |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.78% <ø> (ø)` | |
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndMetricSelect.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZE1ldHJpY1NlbGVjdC50c3g=) | `4.42% <4.42%> (ø)` | |
| [...ntend/src/explore/controlUtils/getControlConfig.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2dldENvbnRyb2xDb25maWcudHM=) | `9.52% <14.28%> (-86.48%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `33.66% <20.00%> (-0.09%)` | :arrow_down: |
| ... and [523 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...c136488](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (3d9ac8e) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `9.08%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 68.45% -9.09%
==========================================
Files 904 827 -77
Lines 45986 41421 -4565
Branches 5552 4300 -1252
==========================================
- Hits 35657 28356 -7301
- Misses 10195 13065 +2870
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.59% <ø> (-6.62%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.38% <100.00%> (-0.07%)` | :arrow_down: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.44% <100.00%> (-0.56%)` | :arrow_down: |
| sqlite | `80.05% <100.00%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.12% <100.00%> (-1.87%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.62% <100.00%> (+0.07%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/dashboard/util/getDirectPathToTabIndex.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERpcmVjdFBhdGhUb1RhYkluZGV4Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [536 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...3d9ac8e](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a change in pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #13578:
URL: https://github.com/apache/superset/pull/13578#discussion_r594475415
##########
File path: superset/databases/commands/update.py
##########
@@ -54,7 +54,7 @@ def run(self) -> Model:
# TODO Improve this simplistic implementation for catching DB conn fails
try:
schemas = database.get_all_schema_names()
- except Exception:
+ except Exception as ex:
Review comment:
We shouldn't because all sorts of info (or even sensitive info) may come out of it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (a4c1cb3) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `6.47%`.
> The diff coverage is `57.00%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 71.06% -6.48%
==========================================
Files 904 827 -77
Lines 45986 41422 -4564
Branches 5552 4300 -1252
==========================================
- Hits 35657 29437 -6220
- Misses 10195 11985 +1790
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.75% <23.56%> (-0.45%)` | :arrow_down: |
| hive | `80.06% <76.38%> (-0.07%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.66% <76.38%> (-0.34%)` | :arrow_down: |
| sqlite | `80.05% <74.53%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `0.00% <0.00%> (-38.89%)` | :arrow_down: |
| [...s/controls/MetricControl/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY0RlZmluaXRpb25WYWx1ZS5qc3g=) | `93.33% <ø> (-0.79%)` | :arrow_down: |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.78% <ø> (ø)` | |
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.35% <0.00%> (-9.81%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndMetricSelect.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZE1ldHJpY1NlbGVjdC50c3g=) | `4.42% <4.42%> (ø)` | |
| ... and [531 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...1835f4f](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (3d9ac8e) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `6.61%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 70.92% -6.62%
==========================================
Files 904 827 -77
Lines 45986 41421 -4565
Branches 5552 4300 -1252
==========================================
- Hits 35657 29377 -6280
- Misses 10195 12044 +1849
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <ø> (-0.48%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.38% <100.00%> (-0.07%)` | :arrow_down: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.44% <100.00%> (-0.56%)` | :arrow_down: |
| sqlite | `80.05% <100.00%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.12% <100.00%> (-1.87%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.62% <100.00%> (+0.07%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [511 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...df42db9](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (c83ca7e) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `9.88%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 67.65% -9.89%
==========================================
Files 904 820 -84
Lines 45986 41120 -4866
Branches 5552 4193 -1359
==========================================
- Hits 35657 27821 -7836
- Misses 10195 13299 +3104
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `48.24% <ø> (-8.96%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.38% <100.00%> (-0.07%)` | :arrow_down: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.44% <100.00%> (-0.56%)` | :arrow_down: |
| sqlite | `80.05% <90.90%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `93.87% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.25% <100.00%> (-1.75%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.62% <100.00%> (+0.07%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...erset-frontend/src/common/hooks/useChangeEffect.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VDaGFuZ2VFZmZlY3QudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [528 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...c83ca7e](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (11021d5) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `6.39%`.
> The diff coverage is `57.51%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 71.14% -6.40%
==========================================
Files 904 827 -77
Lines 45986 41450 -4536
Branches 5552 4300 -1252
==========================================
- Hits 35657 29488 -6169
- Misses 10195 11962 +1767
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.74% <23.56%> (-0.47%)` | :arrow_down: |
| hive | `80.08% <76.95%> (-0.05%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `80.38% <75.46%> (-0.07%)` | :arrow_down: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.79% <77.32%> (-0.21%)` | :arrow_down: |
| sqlite | `80.05% <75.09%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `0.00% <0.00%> (-38.89%)` | :arrow_down: |
| [...s/controls/MetricControl/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY0RlZmluaXRpb25WYWx1ZS5qc3g=) | `93.33% <ø> (-0.79%)` | :arrow_down: |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.78% <ø> (ø)` | |
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndMetricSelect.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZE1ldHJpY1NlbGVjdC50c3g=) | `4.42% <4.42%> (ø)` | |
| [...ntend/src/explore/controlUtils/getControlConfig.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2dldENvbnRyb2xDb25maWcudHM=) | `9.52% <14.28%> (-86.48%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `33.66% <20.00%> (-0.09%)` | :arrow_down: |
| ... and [515 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...c136488](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar merged pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #13578:
URL: https://github.com/apache/superset/pull/13578
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (11021d5) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `6.61%`.
> The diff coverage is `56.33%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 70.92% -6.62%
==========================================
Files 904 827 -77
Lines 45986 41422 -4564
Branches 5552 4300 -1252
==========================================
- Hits 35657 29380 -6277
- Misses 10195 12042 +1847
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.74% <23.56%> (-0.47%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.38% <75.46%> (-0.07%)` | :arrow_down: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.44% <75.46%> (-0.56%)` | :arrow_down: |
| sqlite | `80.05% <75.09%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `0.00% <0.00%> (-38.89%)` | :arrow_down: |
| [...s/controls/MetricControl/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY0RlZmluaXRpb25WYWx1ZS5qc3g=) | `93.33% <ø> (-0.79%)` | :arrow_down: |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.78% <ø> (ø)` | |
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndMetricSelect.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZE1ldHJpY1NlbGVjdC50c3g=) | `4.42% <4.42%> (ø)` | |
| [...ntend/src/explore/controlUtils/getControlConfig.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2dldENvbnRyb2xDb25maWcudHM=) | `9.52% <14.28%> (-86.48%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `33.66% <20.00%> (-0.09%)` | :arrow_down: |
| ... and [528 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...c136488](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (8abbacb) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `6.61%`.
> The diff coverage is `56.57%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 70.92% -6.62%
==========================================
Files 904 828 -76
Lines 45986 41432 -4554
Branches 5552 4307 -1245
==========================================
- Hits 35657 29387 -6270
- Misses 10195 12045 +1850
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <25.58%> (-0.47%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `80.41% <75.81%> (-0.09%)` | :arrow_down: |
| presto | `?` | |
| python | `80.45% <75.81%> (-0.55%)` | :arrow_down: |
| sqlite | `80.03% <74.00%> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLnRzeA==) | `5.55% <0.00%> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `0.00% <0.00%> (-38.89%)` | :arrow_down: |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `44.00% <ø> (-16.00%)` | :arrow_down: |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `10.00% <ø> (-48.00%)` | :arrow_down: |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `3.33% <ø> (-71.51%)` | :arrow_down: |
| [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `6.66% <ø> (-56.67%)` | :arrow_down: |
| [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `77.09% <ø> (-2.45%)` | :arrow_down: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [...ponents/controls/MetricControl/AggregateOption.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FnZ3JlZ2F0ZU9wdGlvbi5qc3g=) | `40.00% <ø> (ø)` | |
| ... and [545 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...2a8a5e5](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #13578:
URL: https://github.com/apache/superset/pull/13578#discussion_r594212362
##########
File path: superset/databases/commands/update.py
##########
@@ -54,7 +54,7 @@ def run(self) -> Model:
# TODO Improve this simplistic implementation for catching DB conn fails
try:
schemas = database.get_all_schema_names()
- except Exception:
+ except Exception as ex:
Review comment:
Should we wrap `ex` in the `DatabaseConnectionFailedError`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (d3b740f) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `6.39%`.
> The diff coverage is `56.80%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 71.14% -6.40%
==========================================
Files 904 827 -77
Lines 45986 41449 -4537
Branches 5552 4300 -1252
==========================================
- Hits 35657 29487 -6170
- Misses 10195 11962 +1767
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <23.56%> (-0.47%)` | :arrow_down: |
| hive | `80.08% <76.20%> (-0.05%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `80.11% <76.20%> (-0.06%)` | :arrow_down: |
| python | `80.79% <76.20%> (-0.21%)` | :arrow_down: |
| sqlite | `80.05% <74.34%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `0.00% <0.00%> (-38.89%)` | :arrow_down: |
| [...s/controls/MetricControl/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY0RlZmluaXRpb25WYWx1ZS5qc3g=) | `93.33% <ø> (-0.79%)` | :arrow_down: |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.78% <ø> (ø)` | |
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.35% <0.00%> (-9.81%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndMetricSelect.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZE1ldHJpY1NlbGVjdC50c3g=) | `4.42% <4.42%> (ø)` | |
| ... and [524 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...c136488](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (c83ca7e) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `6.61%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 70.92% -6.62%
==========================================
Files 904 827 -77
Lines 45986 41422 -4564
Branches 5552 4300 -1252
==========================================
- Hits 35657 29379 -6278
- Misses 10195 12043 +1848
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <ø> (-0.47%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.38% <100.00%> (-0.07%)` | :arrow_down: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.44% <100.00%> (-0.56%)` | :arrow_down: |
| sqlite | `80.05% <90.90%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `93.87% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.25% <100.00%> (-1.75%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.62% <100.00%> (+0.07%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [513 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...c83ca7e](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (a4c1cb3) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `6.45%`.
> The diff coverage is `57.00%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 71.08% -6.46%
==========================================
Files 904 827 -77
Lines 45986 41450 -4536
Branches 5552 4300 -1252
==========================================
- Hits 35657 29464 -6193
- Misses 10195 11986 +1791
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.75% <23.56%> (-0.45%)` | :arrow_down: |
| hive | `80.08% <76.38%> (-0.05%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.68% <76.38%> (-0.32%)` | :arrow_down: |
| sqlite | `80.05% <74.53%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `0.00% <0.00%> (-38.89%)` | :arrow_down: |
| [...s/controls/MetricControl/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY0RlZmluaXRpb25WYWx1ZS5qc3g=) | `93.33% <ø> (-0.79%)` | :arrow_down: |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.78% <ø> (ø)` | |
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.35% <0.00%> (-9.81%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndMetricSelect.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZE1ldHJpY1NlbGVjdC50c3g=) | `4.42% <4.42%> (ø)` | |
| ... and [523 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...c136488](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (8abbacb) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `6.85%`.
> The diff coverage is `55.45%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 70.68% -6.86%
==========================================
Files 904 828 -76
Lines 45986 41432 -4554
Branches 5552 4307 -1245
==========================================
- Hits 35657 29285 -6372
- Misses 10195 12147 +1952
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <25.58%> (-0.47%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.03% <74.00%> (-0.97%)` | :arrow_down: |
| sqlite | `80.03% <74.00%> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLnRzeA==) | `5.55% <0.00%> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `0.00% <0.00%> (-38.89%)` | :arrow_down: |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `44.00% <ø> (-16.00%)` | :arrow_down: |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `10.00% <ø> (-48.00%)` | :arrow_down: |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `3.33% <ø> (-71.51%)` | :arrow_down: |
| [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `6.66% <ø> (-56.67%)` | :arrow_down: |
| [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `77.09% <ø> (-2.45%)` | :arrow_down: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [...ponents/controls/MetricControl/AggregateOption.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FnZ3JlZ2F0ZU9wdGlvbi5qc3g=) | `40.00% <ø> (ø)` | |
| ... and [558 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...2a8a5e5](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (11021d5) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `6.39%`.
> The diff coverage is `57.51%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 71.14% -6.40%
==========================================
Files 904 827 -77
Lines 45986 41450 -4536
Branches 5552 4300 -1252
==========================================
- Hits 35657 29488 -6169
- Misses 10195 11962 +1767
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.74% <23.56%> (-0.47%)` | :arrow_down: |
| hive | `80.08% <76.95%> (-0.05%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `80.38% <75.46%> (-0.07%)` | :arrow_down: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.79% <77.32%> (-0.21%)` | :arrow_down: |
| sqlite | `80.05% <75.09%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `0.00% <0.00%> (-38.89%)` | :arrow_down: |
| [...s/controls/MetricControl/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY0RlZmluaXRpb25WYWx1ZS5qc3g=) | `93.33% <ø> (-0.79%)` | :arrow_down: |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.78% <ø> (ø)` | |
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndMetricSelect.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZE1ldHJpY1NlbGVjdC50c3g=) | `4.42% <4.42%> (ø)` | |
| [...ntend/src/explore/controlUtils/getControlConfig.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2dldENvbnRyb2xDb25maWcudHM=) | `9.52% <14.28%> (-86.48%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `33.66% <20.00%> (-0.09%)` | :arrow_down: |
| ... and [515 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...c136488](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (0af90a4) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **increase** coverage by `3.32%`.
> The diff coverage is `77.32%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
+ Coverage 77.53% 80.86% +3.32%
==========================================
Files 904 304 -600
Lines 45986 24816 -21170
Branches 5552 0 -5552
==========================================
- Hits 35657 20068 -15589
+ Misses 10195 4748 -5447
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `80.08% <76.95%> (-0.05%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `80.44% <76.95%> (-0.05%)` | :arrow_down: |
| presto | `80.11% <76.95%> (-0.06%)` | :arrow_down: |
| python | `80.86% <77.32%> (-0.14%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.78% <ø> (ø)` | |
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [superset/cli.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `33.66% <20.00%> (-0.09%)` | :arrow_down: |
| [superset/utils/data.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0YS5weQ==) | `27.94% <27.94%> (ø)` | |
| [superset/examples/big\_data.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlnX2RhdGEucHk=) | `50.00% <50.00%> (ø)` | |
| [superset/db\_engine\_specs/crate.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NyYXRlLnB5) | `92.30% <92.30%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.37% <93.33%> (-0.29%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `88.68% <100.00%> (+0.56%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `95.96% <100.00%> (+0.39%)` | :arrow_up: |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `99.36% <100.00%> (+0.22%)` | :arrow_up: |
| ... and [600 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...c83ca7e](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (a4c1cb3) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `6.83%`.
> The diff coverage is `55.84%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 70.69% -6.84%
==========================================
Files 904 827 -77
Lines 45986 41422 -4564
Branches 5552 4300 -1252
==========================================
- Hits 35657 29285 -6372
- Misses 10195 12137 +1942
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.75% <23.56%> (-0.45%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.05% <74.53%> (-0.95%)` | :arrow_down: |
| sqlite | `80.05% <74.53%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `0.00% <0.00%> (-38.89%)` | :arrow_down: |
| [...s/controls/MetricControl/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY0RlZmluaXRpb25WYWx1ZS5qc3g=) | `93.33% <ø> (-0.79%)` | :arrow_down: |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.78% <ø> (ø)` | |
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.37% <0.00%> (-60.79%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndMetricSelect.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZE1ldHJpY1NlbGVjdC50c3g=) | `4.42% <4.42%> (ø)` | |
| ... and [541 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...1835f4f](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (8abbacb) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `6.58%`.
> The diff coverage is `56.57%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 70.95% -6.59%
==========================================
Files 904 828 -76
Lines 45986 41432 -4554
Branches 5552 4307 -1245
==========================================
- Hits 35657 29398 -6259
- Misses 10195 12034 +1839
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <25.58%> (-0.47%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.37% <74.36%> (-0.09%)` | :arrow_down: |
| postgres | `80.41% <75.81%> (-0.09%)` | :arrow_down: |
| presto | `?` | |
| python | `80.49% <75.81%> (-0.51%)` | :arrow_down: |
| sqlite | `80.03% <74.00%> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLnRzeA==) | `5.55% <0.00%> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `0.00% <0.00%> (-38.89%)` | :arrow_down: |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `44.00% <ø> (-16.00%)` | :arrow_down: |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `10.00% <ø> (-48.00%)` | :arrow_down: |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `3.33% <ø> (-71.51%)` | :arrow_down: |
| [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `6.66% <ø> (-56.67%)` | :arrow_down: |
| [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `77.09% <ø> (-2.45%)` | :arrow_down: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [...ponents/controls/MetricControl/AggregateOption.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FnZ3JlZ2F0ZU9wdGlvbi5qc3g=) | `40.00% <ø> (ø)` | |
| ... and [543 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...2a8a5e5](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (c83ca7e) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `6.57%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 70.96% -6.58%
==========================================
Files 904 827 -77
Lines 45986 41422 -4564
Branches 5552 4300 -1252
==========================================
- Hits 35657 29395 -6262
- Misses 10195 12027 +1832
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <ø> (-0.47%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.38% <100.00%> (-0.07%)` | :arrow_down: |
| postgres | `80.42% <100.00%> (-0.08%)` | :arrow_down: |
| presto | `?` | |
| python | `80.51% <100.00%> (-0.49%)` | :arrow_down: |
| sqlite | `80.05% <90.90%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `93.87% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.25% <100.00%> (-1.75%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.62% <100.00%> (+0.07%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [511 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...c83ca7e](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (a4c1cb3) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `6.38%`.
> The diff coverage is `57.00%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 71.15% -6.39%
==========================================
Files 904 827 -77
Lines 45986 41450 -4536
Branches 5552 4300 -1252
==========================================
- Hits 35657 29492 -6165
- Misses 10195 11958 +1763
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.75% <23.56%> (-0.45%)` | :arrow_down: |
| hive | `80.08% <76.38%> (-0.05%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `80.11% <76.38%> (-0.06%)` | :arrow_down: |
| python | `80.79% <76.38%> (-0.21%)` | :arrow_down: |
| sqlite | `80.05% <74.53%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `0.00% <0.00%> (-38.89%)` | :arrow_down: |
| [...s/controls/MetricControl/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY0RlZmluaXRpb25WYWx1ZS5qc3g=) | `93.33% <ø> (-0.79%)` | :arrow_down: |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.78% <ø> (ø)` | |
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.35% <0.00%> (-9.81%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [...ontrols/DndColumnSelectControl/DndMetricSelect.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZE1ldHJpY1NlbGVjdC50c3g=) | `4.42% <4.42%> (ø)` | |
| ... and [523 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...c136488](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (0af90a4) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **increase** coverage by `3.32%`.
> The diff coverage is `77.32%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
+ Coverage 77.53% 80.86% +3.32%
==========================================
Files 904 304 -600
Lines 45986 24816 -21170
Branches 5552 0 -5552
==========================================
- Hits 35657 20068 -15589
+ Misses 10195 4748 -5447
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `80.08% <76.95%> (-0.05%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `80.44% <76.95%> (-0.05%)` | :arrow_down: |
| presto | `80.11% <76.95%> (-0.06%)` | :arrow_down: |
| python | `80.86% <77.32%> (-0.14%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.78% <ø> (ø)` | |
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [superset/cli.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `33.66% <20.00%> (-0.09%)` | :arrow_down: |
| [superset/utils/data.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0YS5weQ==) | `27.94% <27.94%> (ø)` | |
| [superset/examples/big\_data.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlnX2RhdGEucHk=) | `50.00% <50.00%> (ø)` | |
| [superset/db\_engine\_specs/crate.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NyYXRlLnB5) | `92.30% <92.30%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.37% <93.33%> (-0.29%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `88.68% <100.00%> (+0.56%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `95.96% <100.00%> (+0.39%)` | :arrow_up: |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `99.36% <100.00%> (+0.22%)` | :arrow_up: |
| ... and [600 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...2a8a5e5](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (11021d5) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `6.61%`.
> The diff coverage is `56.33%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 70.92% -6.62%
==========================================
Files 904 827 -77
Lines 45986 41422 -4564
Branches 5552 4300 -1252
==========================================
- Hits 35657 29379 -6278
- Misses 10195 12043 +1848
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <23.56%> (-0.47%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.38% <75.46%> (-0.07%)` | :arrow_down: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.44% <75.46%> (-0.56%)` | :arrow_down: |
| sqlite | `80.05% <75.09%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `0.00% <0.00%> (-38.89%)` | :arrow_down: |
| [...s/controls/MetricControl/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY0RlZmluaXRpb25WYWx1ZS5qc3g=) | `93.33% <ø> (-0.79%)` | :arrow_down: |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.78% <ø> (ø)` | |
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndMetricSelect.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZE1ldHJpY1NlbGVjdC50c3g=) | `4.42% <4.42%> (ø)` | |
| [...ntend/src/explore/controlUtils/getControlConfig.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2dldENvbnRyb2xDb25maWcudHM=) | `9.52% <14.28%> (-86.48%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `33.66% <20.00%> (-0.09%)` | :arrow_down: |
| ... and [528 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...c136488](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (3d9ac8e) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `6.61%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 70.92% -6.62%
==========================================
Files 904 827 -77
Lines 45986 41421 -4565
Branches 5552 4300 -1252
==========================================
- Hits 35657 29377 -6280
- Misses 10195 12044 +1849
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <ø> (-0.48%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.38% <100.00%> (-0.07%)` | :arrow_down: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.44% <100.00%> (-0.56%)` | :arrow_down: |
| sqlite | `80.05% <100.00%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.12% <100.00%> (-1.87%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.62% <100.00%> (+0.07%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [511 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...1835f4f](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (11021d5) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `6.39%`.
> The diff coverage is `57.51%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 71.14% -6.40%
==========================================
Files 904 827 -77
Lines 45986 41450 -4536
Branches 5552 4300 -1252
==========================================
- Hits 35657 29488 -6169
- Misses 10195 11962 +1767
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.74% <23.56%> (-0.47%)` | :arrow_down: |
| hive | `80.08% <76.95%> (-0.05%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `80.38% <75.46%> (-0.07%)` | :arrow_down: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.79% <77.32%> (-0.21%)` | :arrow_down: |
| sqlite | `80.05% <75.09%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `0.00% <0.00%> (-38.89%)` | :arrow_down: |
| [...s/controls/MetricControl/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY0RlZmluaXRpb25WYWx1ZS5qc3g=) | `93.33% <ø> (-0.79%)` | :arrow_down: |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.78% <ø> (ø)` | |
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndMetricSelect.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZE1ldHJpY1NlbGVjdC50c3g=) | `4.42% <4.42%> (ø)` | |
| [...ntend/src/explore/controlUtils/getControlConfig.ts](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2dldENvbnRyb2xDb25maWcudHM=) | `9.52% <14.28%> (-86.48%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `33.66% <20.00%> (-0.09%)` | :arrow_down: |
| ... and [515 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...c83ca7e](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (8abbacb) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `6.56%`.
> The diff coverage is `56.57%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 70.97% -6.57%
==========================================
Files 904 828 -76
Lines 45986 41460 -4526
Branches 5552 4307 -1245
==========================================
- Hits 35657 29425 -6232
- Misses 10195 12035 +1840
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <25.58%> (-0.47%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.37% <74.36%> (-0.09%)` | :arrow_down: |
| postgres | `80.42% <75.81%> (-0.07%)` | :arrow_down: |
| presto | `?` | |
| python | `80.51% <75.81%> (-0.49%)` | :arrow_down: |
| sqlite | `80.03% <74.00%> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLnRzeA==) | `5.55% <0.00%> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `0.00% <0.00%> (-38.89%)` | :arrow_down: |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `44.00% <ø> (-16.00%)` | :arrow_down: |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `10.00% <ø> (-48.00%)` | :arrow_down: |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `3.33% <ø> (-71.51%)` | :arrow_down: |
| [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `6.66% <ø> (-56.67%)` | :arrow_down: |
| [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `77.09% <ø> (-2.45%)` | :arrow_down: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [...ponents/controls/MetricControl/AggregateOption.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FnZ3JlZ2F0ZU9wdGlvbi5qc3g=) | `40.00% <ø> (ø)` | |
| ... and [535 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...2a8a5e5](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13578: fix: better handle datasource exceptions
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13578:
URL: https://github.com/apache/superset/pull/13578#issuecomment-797449620
# [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=h1) Report
> Merging [#13578](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=desc) (8abbacb) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `6.47%`.
> The diff coverage is `56.79%`.
[](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13578 +/- ##
==========================================
- Coverage 77.53% 71.06% -6.48%
==========================================
Files 904 828 -76
Lines 45986 41460 -4526
Branches 5552 4307 -1245
==========================================
- Hits 35657 29462 -6195
- Misses 10195 11998 +1803
+ Partials 134 0 -134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <25.58%> (-0.47%)` | :arrow_down: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.37% <74.36%> (-0.09%)` | :arrow_down: |
| postgres | `80.42% <75.81%> (-0.07%)` | :arrow_down: |
| presto | `80.10% <75.81%> (-0.07%)` | :arrow_down: |
| python | `80.66% <76.17%> (-0.34%)` | :arrow_down: |
| sqlite | `80.03% <74.00%> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLnRzeA==) | `5.55% <0.00%> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `0.00% <0.00%> (-38.89%)` | :arrow_down: |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `44.00% <ø> (-16.00%)` | :arrow_down: |
| [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `10.00% <ø> (-48.00%)` | :arrow_down: |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `3.33% <ø> (-71.51%)` | :arrow_down: |
| [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `6.66% <ø> (-56.67%)` | :arrow_down: |
| [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `77.09% <ø> (-2.45%)` | :arrow_down: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [...ponents/controls/MetricControl/AggregateOption.jsx](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FnZ3JlZ2F0ZU9wdGlvbi5qc3g=) | `40.00% <ø> (ø)` | |
| ... and [532 more](https://codecov.io/gh/apache/superset/pull/13578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=footer). Last update [5fca19d...2a8a5e5](https://codecov.io/gh/apache/superset/pull/13578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org