[PR] Add istio ambient mode E2E and bump up backend version [skywalking-rover]

["mrproliu (via GitHub)" <gi...@apache.org>]

mrproliu opened a new pull request, #216:
URL: https://github.com/apache/skywalking-rover/pull/216

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add istio ambient mode E2E and bump up backend version [skywalking-rover]

["Copilot (via GitHub)" <gi...@apache.org>]

Copilot commented on code in PR #216:
URL: https://github.com/apache/skywalking-rover/pull/216#discussion_r3701060440


##########
test/e2e/base/scripts/prepare/setup-e2e-shell/install-istioctl.sh:
##########
@@ -19,11 +19,25 @@
 # under the License.
 # ----------------------------------------------------------------------------
 
+set -ex
+
 BASE_DIR=$1
 BIN_DIR=$2
 

Review Comment:
   This script assumes both positional args and ISTIO_VERSION are set; if any are missing/empty, it may write into unexpected locations (e.g., "/istioctl") or fail with a less actionable error. Add explicit parameter/env validation when assigning BASE_DIR/BIN_DIR.



##########
test/e2e/cases/ambient/verify/resolution-health.sh:
##########
@@ -0,0 +1,55 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Regression guard for the ambient remote address resolution. Rover periodically logs a
+# "remote address resolve summary" with how many remote addresses it resolved through the
+# ztunnel inbound/outbound correlation versus how many stayed unresolved and were sent as a
+# raw IP. On the ambient data path the conntrack(netlink) lookup is essentially always empty,
+# so the ztunnel correlation MUST carry the resolution: if it regresses, every ClusterIP hop
+# degrades to a raw IP node and the topology silently loses its shape. Both checks flip to
+# false in that case.
+#
+# NOTE: uses grep -c/-oE(which read all of the input) rather than grep -q, see the sibling
+# ztunnel-binding.sh for why.
+set -e
+
+pod=$(kubectl get pod -l name=skywalking-rover -o jsonpath='{.items[0].metadata.name}' 2>/dev/null)
+line=$(kubectl logs "${pod}" --tail=-1 2>/dev/null | grep -a 'remote address resolve summary' | tail -1)
+
+printf '%s\n' "${line}" >&2
+
+# both numbers are read as CUMULATIVE totals so the comparison below comparses like with

Review Comment:
   Typo in the comment: "comparses" should be "compares".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add istio ambient mode E2E and bump up backend version [skywalking-rover]

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng merged PR #216:
URL: https://github.com/apache/skywalking-rover/pull/216


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org