You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/03/01 16:45:10 UTC
[GitHub] [netbeans] dmochalov opened a new pull request #1995:
[NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
dmochalov opened a new pull request #1995: [NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
URL: https://github.com/apache/netbeans/pull/1995
Adding the ability to delete a tag from a remote repository using integrated Git Client. Before a user could delete a branch but could not delete a tag. Now, when performing git push... a user can select locally deleted tag and Git Client will perform git push :refs/tags/{tag_name_to_delete}
I tested the implementation locally using GitHub. It looks like this:
It's my first PR so any feedback would be highly appreciated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #1995:
[NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #1995: [NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
URL: https://github.com/apache/netbeans/pull/1995#issuecomment-595444272
@dmochalov thank you - looks sane to me. Yes, please squash the commits, in theory github can do this when merging, but that requires the accounts from which the commits were created, to have public real name and email.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request
#1995: [NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #1995: [NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
URL: https://github.com/apache/netbeans/pull/1995#discussion_r387248386
##########
File path: ide/git/src/org/netbeans/modules/git/ui/push/PushMapping.java
##########
@@ -224,18 +224,58 @@ boolean isCreateBranchMapping () {
}
public static final class PushTagMapping extends PushMapping {
- private final GitTag tag;
+ private final GitTag tag; //local tag
private final boolean isUpdate;
-
+ private final String remoteTagName;
+
+ /**
+ * *
+ * Tag that we need to delete in the remote repository
+ *
+ * @param remoteName remote tag name
+ */
+ public PushTagMapping(String remoteName) {
+ super(null, null, remoteName, false, false, remoteName != null);
+ this.tag = null;
+ this.isUpdate = remoteName != null;
+ this.remoteTagName = remoteName;
+ }
+
+ /**
+ * Adding or updating tag in the remote repository
+ *
+ * @param tag representation of a local tag
+ * @param remoteName remote tag name, can be null. If null than we crate
Review comment:
crate => create
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing closed pull request #1995:
[NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing closed pull request #1995: [NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
URL: https://github.com/apache/netbeans/pull/1995
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request
#1995: [NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #1995: [NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
URL: https://github.com/apache/netbeans/pull/1995#discussion_r387247323
##########
File path: ide/git/src/org/netbeans/modules/git/ui/push/PushBranchesStep.java
##########
@@ -98,6 +98,13 @@ public HelpCtx getHelp() {
return new HelpCtx(PushBranchesStep.class);
}
+ /**
+ * *
+ * @param cfg Congiruration of the remote repository including urls of
+ * remote
+ * @param branches list of all brances in the remote repo
Review comment:
Fix typo: list of all branches in the remote repo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request
#1995: [NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #1995: [NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
URL: https://github.com/apache/netbeans/pull/1995#discussion_r387246126
##########
File path: ide/git/src/org/netbeans/modules/git/ui/push/PushAction.java
##########
@@ -341,10 +344,20 @@ protected void logUpdates (File repository, Map<String, GitTransportUpdate> upda
}
}
} else {
- logger.outputLine(NbBundle.getMessage(PushAction.class, "MSG_PushAction.updates.updateTag", new Object[] { //NOI18N
- update.getLocalName(),
- update.getResult(),
- }));
+ //tag deleting or updating
+ if (update.getNewObjectId() == null && update.getOldObjectId() != null) {
+ //deleting tag from remote
+ logger.outputLine(NbBundle.getMessage(PushAction.class, "MSG_PushAction.updates.deleteTag", new Object[]{ //NOI18N
+ update.getRemoteName(),
+ update.getOldObjectId(),
+ update.getResult(),}));
+ } else {
+ //updating or adding tag to the remoteё
Review comment:
This should not be there: Ń‘
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #1995:
[NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #1995: [NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
URL: https://github.com/apache/netbeans/pull/1995#issuecomment-594132512
I assume, that you are aware of the license header in the edited files and thus agree that you are willing to donate the changeset to the ASF.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request
#1995: [NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #1995: [NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
URL: https://github.com/apache/netbeans/pull/1995#discussion_r387247085
##########
File path: ide/git/src/org/netbeans/modules/git/ui/push/PushBranchesStep.java
##########
@@ -98,6 +98,13 @@ public HelpCtx getHelp() {
return new HelpCtx(PushBranchesStep.class);
}
+ /**
+ * *
+ * @param cfg Congiruration of the remote repository including urls of
Review comment:
Please keep it on one line and fix typo: "Configuration of the remote repository including urls of remote"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request
#1995: [NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #1995: [NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
URL: https://github.com/apache/netbeans/pull/1995#discussion_r387246483
##########
File path: ide/git/src/org/netbeans/modules/git/ui/push/PushBranchesStep.java
##########
@@ -98,6 +98,13 @@ public HelpCtx getHelp() {
return new HelpCtx(PushBranchesStep.class);
}
+ /**
+ * *
Review comment:
One star to much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request
#1995: [NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #1995: [NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
URL: https://github.com/apache/netbeans/pull/1995#discussion_r387249462
##########
File path: ide/libs.git/src/org/netbeans/libs/git/GitTransportUpdate.java
##########
@@ -74,14 +74,29 @@
this.type = getType(update.getLocalName());
}
- GitTransportUpdate (URIish uri, RemoteRefUpdate update, Map<String, GitBranch> remoteBranches) {
+ /**
+ * *
Review comment:
to many stars.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request
#1995: [NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #1995: [NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
URL: https://github.com/apache/netbeans/pull/1995#discussion_r387248017
##########
File path: ide/git/src/org/netbeans/modules/git/ui/push/PushMapping.java
##########
@@ -224,18 +224,58 @@ boolean isCreateBranchMapping () {
}
public static final class PushTagMapping extends PushMapping {
- private final GitTag tag;
+ private final GitTag tag; //local tag
private final boolean isUpdate;
-
+ private final String remoteTagName;
+
+ /**
+ * *
Review comment:
one star to many
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request
#1995: [NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #1995: [NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
URL: https://github.com/apache/netbeans/pull/1995#discussion_r387247681
##########
File path: ide/git/src/org/netbeans/modules/git/ui/push/PushBranchesStep.java
##########
@@ -154,6 +162,8 @@ protected void perform () {
}
}
boolean preselected = !conflicted && updateNeeded;
+
+ //add current brunch in the list for update or for adding
Review comment:
While brunch is nice, most probably branch was meant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dmochalov commented on issue #1995: [NETBEANS-3929]
Adding the ability to delete a tag from a remote repo.
Posted by GitBox <gi...@apache.org>.
dmochalov commented on issue #1995: [NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
URL: https://github.com/apache/netbeans/pull/1995#issuecomment-595394909
@matthiasblaesing , thank you for your response. I corrected the typos. Should i squash them to one commit?
Yes I am aware of the license header and agree to donate the changeset to the ASF.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #1995:
[NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #1995: [NETBEANS-3929] Adding the ability to delete a tag from a remote repo.
URL: https://github.com/apache/netbeans/pull/1995#issuecomment-595854118
Forget it - merged via 7d17072e22ca45228e57ef2399ecfd7ac37c53e2. Thank you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists