You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/05/30 00:07:42 UTC
[GitHub] [incubator-druid] gianm commented on a change in pull request
#7747: Remove keepSegmentGranularity option for compaction
gianm commented on a change in pull request #7747: Remove keepSegmentGranularity option for compaction
URL: https://github.com/apache/incubator-druid/pull/7747#discussion_r288814604
##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java
##########
@@ -181,19 +177,10 @@ public CompactionTask(
throw new IAE("Interval[%s] is empty, must specify a nonempty interval", interval);
}
- if ((keepSegmentGranularity != null && keepSegmentGranularity) && segmentGranularity != null) {
- throw new IAE("keepSegmentGranularity and segmentGranularity can't be used together");
- }
-
- if (keepSegmentGranularity != null) {
- log.warn("keepSegmentGranularity is deprecated. Set a proper segmentGranularity instead");
- }
-
this.interval = interval;
this.segments = segments;
this.dimensionsSpec = dimensionsSpec == null ? dimensions : dimensionsSpec;
this.metricsSpec = metricsSpec;
- this.keepSegmentGranularity = keepSegmentGranularity;
this.segmentGranularity = segmentGranularity;
Review comment:
Please include a null check for `segmentGranularity` with a nice error message. It's especially important since people with older ingest specs that _don't_ include segmentGranularity need a nice message telling them what to change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org