[GitHub] [inlong] healchow commented on a diff in pull request #6043: [INLONG-6042][Manager] Support delete DataNode by name

[GitBox <gi...@apache.org>]

healchow commented on code in PR #6043:
URL: https://github.com/apache/inlong/pull/6043#discussion_r983283632


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/node/DataNodeServiceImpl.java:
##########
@@ -142,6 +142,20 @@ public Boolean delete(Integer id, String operator) {
             return false;
         }
 
+        return delete(entity, operator);
+    }
+
+    @Override
+    public Boolean deleteByName(String name, String operator) {
+        DataNodeEntity entity = dataNodeMapper.selectByNameAndType(name, null);

Review Comment:
   There may return more than one entity.
   Suggested make tye type not null.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org