You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/03/17 11:59:42 UTC

[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1598: feat: check if the service is using by route when deleting

tokers commented on a change in pull request #1598:
URL: https://github.com/apache/apisix-dashboard/pull/1598#discussion_r595950219



##########
File path: api/test/e2enew/service/service_test.go
##########
@@ -82,9 +83,9 @@ var _ = ginkgo.Describe("create service without plugin", func() {
 			Method: http.MethodPut,
 			Path:   "/apisix/admin/routes/r1",
 			Body: `{
-				"uri": "/server_port",
-				"service_id": "s1"
-			}`,
+ 				"uri": "/server_port",

Review comment:
       Seems that you added some empty spaces?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org