You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2022/12/13 08:29:42 UTC
[Impala-ASF-CR] IMPALA-11794: Fix flakiness of TestLoadDataExternal.test load by using dedicated table name
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19350
Change subject: IMPALA-11794: Fix flakiness of TestLoadDataExternal.test_load by using dedicated table name
......................................................................
IMPALA-11794: Fix flakiness of TestLoadDataExternal.test_load by using dedicated table name
IMPALA-11736 adds TestLoadDataExternal that uses the same table name
used by an existing test (TestLoadData). These two tests both will clean
up the test tables at the beginning and at the end. If they run
concurrently, one of them will fail. Note that e2e tests are ran in
parallel by default.
This patch fixes TestLoadDataExternal to use a dedicated table name.
Tests:
- Verified locally
Change-Id: I2ee29c93fb1dcf14c6adb9f320fde70baa72cadd
---
M tests/metadata/test_load.py
1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/19350/1
--
To view, visit http://gerrit.cloudera.org:8080/19350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ee29c93fb1dcf14c6adb9f320fde70baa72cadd
Gerrit-Change-Number: 19350
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11794: Fix flakiness of TestLoadDataExternal.test load by using dedicated table name
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19350 )
Change subject: IMPALA-11794: Fix flakiness of TestLoadDataExternal.test_load by using dedicated table name
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12019/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ee29c93fb1dcf14c6adb9f320fde70baa72cadd
Gerrit-Change-Number: 19350
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 13 Dec 2022 08:49:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11794: Fix flakiness of TestLoadDataExternal.test load by using dedicated table name
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19350 )
Change subject: IMPALA-11794: Fix flakiness of TestLoadDataExternal.test_load by using dedicated table name
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8902/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/19350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ee29c93fb1dcf14c6adb9f320fde70baa72cadd
Gerrit-Change-Number: 19350
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 13 Dec 2022 16:39:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11794: Fix flakiness of TestLoadDataExternal.test load by using dedicated table name
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19350 )
Change subject: IMPALA-11794: Fix flakiness of TestLoadDataExternal.test_load by using dedicated table name
......................................................................
Patch Set 1: Code-Review+2
Thanks, I overlooked that they'd run in parallel.
--
To view, visit http://gerrit.cloudera.org:8080/19350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ee29c93fb1dcf14c6adb9f320fde70baa72cadd
Gerrit-Change-Number: 19350
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 13 Dec 2022 16:39:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11794: Fix flakiness of TestLoadDataExternal.test load by using dedicated table name
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19350 )
Change subject: IMPALA-11794: Fix flakiness of TestLoadDataExternal.test_load by using dedicated table name
......................................................................
IMPALA-11794: Fix flakiness of TestLoadDataExternal.test_load by using dedicated table name
IMPALA-11736 adds TestLoadDataExternal that uses the same table name
used by an existing test (TestLoadData). These two tests both will clean
up the test tables at the beginning and at the end. If they run
concurrently, one of them will fail. Note that e2e tests are ran in
parallel by default.
This patch fixes TestLoadDataExternal to use a dedicated table name.
Tests:
- Verified locally
Change-Id: I2ee29c93fb1dcf14c6adb9f320fde70baa72cadd
Reviewed-on: http://gerrit.cloudera.org:8080/19350
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/metadata/test_load.py
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Michael Smith: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ee29c93fb1dcf14c6adb9f320fde70baa72cadd
Gerrit-Change-Number: 19350
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11794: Fix flakiness of TestLoadDataExternal.test load by using dedicated table name
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19350 )
Change subject: IMPALA-11794: Fix flakiness of TestLoadDataExternal.test_load by using dedicated table name
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ee29c93fb1dcf14c6adb9f320fde70baa72cadd
Gerrit-Change-Number: 19350
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 13 Dec 2022 21:49:29 +0000
Gerrit-HasComments: No