You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/06 22:14:53 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #6954: [AIRFLOW-4355] removed task should not lead to dagrun success

mik-laj commented on a change in pull request #6954: [AIRFLOW-4355] removed task should not lead to dagrun success
URL: https://github.com/apache/airflow/pull/6954#discussion_r363508864
 
 

 ##########
 File path: airflow/models/dag.py
 ##########
 @@ -549,6 +549,11 @@ def tasks(self, val):
     def task_ids(self):
         return list(self.task_dict.keys())
 
+    @property
+    def active_tasks(self):
+        """Return tasks in a DAG. Needed as part of determining overall DagRun outcome"""
+        return [t for t in self.tasks]
 
 Review comment:
   Can you explain the benefit of introducing this method? In my opinion we don't need it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services