You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/10/29 10:22:46 UTC
[GitHub] [dolphinscheduler] wcmolin opened a new pull request, #12606: [Fix-12586] [Master] Repeat running the complement process instance w…
wcmolin opened a new pull request, #12606:
URL: https://github.com/apache/dolphinscheduler/pull/12606
closed by #12586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #12606: [Fix-12586] [Master] Repeat running the complement process instance will generate redundant complement instances
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #12606:
URL: https://github.com/apache/dolphinscheduler/pull/12606#discussion_r1021320515
##########
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java:
##########
@@ -534,6 +534,10 @@ private boolean processComplementData() {
scheduleDate = complementListDate.get(0);
} else if (processInstance.getState().typeIsFinished()) {
endProcess();
+ // rerun process instance of complement didn't need create the next process complement
+ if (processInstance.getCommandType() == CommandType.REPEAT_RUNNING) {
+ return true;
+ }
Review Comment:
It's a feature, not a bugfix, should not add into 2.0.x version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina merged pull request #12606: [Fix-12586] [Master] Repeat running the complement process instance will generate redundant complement instances
Posted by GitBox <gi...@apache.org>.
JinyLeeChina merged PR #12606:
URL: https://github.com/apache/dolphinscheduler/pull/12606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #12606: [Fix-12586] [Master] Repeat running the complement process instance will generate redundant complement instances
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #12606:
URL: https://github.com/apache/dolphinscheduler/pull/12606#issuecomment-1295799594
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=12606)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12606&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12606&resolved=false&types=BUG) [62 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12606&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12606&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12606&resolved=false&types=VULNERABILITY) [10 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12606&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12606&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12606&resolved=false&types=SECURITY_HOTSPOT) [11 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12606&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12606&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12606&resolved=false&types=CODE_SMELL) [1035 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12606&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12606&metric=new_coverage&view=list) [17.5% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12606&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12606&metric=new_duplicated_lines_density&view=list) [5.5% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12606&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #12606: [Fix-12586] [Master] Repeat running the complement process instance will generate redundant complement instances
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #12606:
URL: https://github.com/apache/dolphinscheduler/pull/12606#issuecomment-1295796522
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/12606?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`2.0.8-prepare@0f8689f`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 2.0.8-prepare #12606 +/- ##
================================================
Coverage ? 20.79%
Complexity ? 1604
================================================
Files ? 540
Lines ? 22986
Branches ? 2744
================================================
Hits ? 4781
Misses ? 17713
Partials ? 492
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #12606: [Fix-12586] [Master] Repeat running the complement process instance will generate redundant complement instances
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #12606:
URL: https://github.com/apache/dolphinscheduler/pull/12606#discussion_r1008983363
##########
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java:
##########
@@ -534,6 +534,10 @@ private boolean processComplementData() {
scheduleDate = complementListDate.get(0);
} else if (processInstance.getState().typeIsFinished()) {
endProcess();
+ // rerun process instance of complement didn't need create the next process complement
+ if (processInstance.getCommandType() == CommandType.REPEAT_RUNNING) {
+ return true;
+ }
Review Comment:
Discusstion in https://github.com/apache/dolphinscheduler/issues/12586#issuecomment-1296455628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org