You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/05/23 18:26:31 UTC

[GitHub] [fineract] percyashu opened a new pull request #930: FINERACT-959 make javac fail for rawtypes

percyashu opened a new pull request #930:
URL: https://github.com/apache/fineract/pull/930


   ## Description
   Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
   
   - [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
   
   - [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
   
   - [ ] Integration tests have been created/updated for verifying the changes made.
   
   - [ ] All Integrations tests are passing with the new commits.
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] percyashu closed pull request #930: FINERACT-959 make javac fail for rawtypes

Posted by GitBox <gi...@apache.org>.
percyashu closed pull request #930:
URL: https://github.com/apache/fineract/pull/930


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] percyashu commented on pull request #930: FINERACT-959 make javac fail for rawtypes

Posted by GitBox <gi...@apache.org>.
percyashu commented on pull request #930:
URL: https://github.com/apache/fineract/pull/930#issuecomment-633115716


   @awasum and @vorburger I will look into an appropriate fix for the HashMap rawtype warning wasn't sure which arguments it require . I notice some in some test it was it was suppressed along with unchecked warning.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] percyashu commented on pull request #930: FINERACT-959 make javac fail for rawtypes

Posted by GitBox <gi...@apache.org>.
percyashu commented on pull request #930:
URL: https://github.com/apache/fineract/pull/930#issuecomment-638509709


   @vorburger it is a lot of work and will surely look into it later. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] awasum commented on pull request #930: FINERACT-959 make javac fail for rawtypes

Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #930:
URL: https://github.com/apache/fineract/pull/930#issuecomment-633671249






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #930: FINERACT-959 make javac fail for rawtypes

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #930:
URL: https://github.com/apache/fineract/pull/930#issuecomment-637749312


   @percyashu will you pick this up and finish it? Or is this a lot of work and not worth it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org