You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by "Rory I. Sinclair" <ro...@levelfour.com> on 2003/07/07 13:03:44 UTC

Tiny patch to CvsTagDiff.java

Hi

	Forgive a wet-behind-the-ears newbie here, this is my first contrib.

	I have made a tiny patch to CvsTagDiff.java to support multiple packages.
CVS itself happily accepts a space-separated list of packages/files to
perform the rdiff command upon, but the Ant task (at least in 1.5.3) fails
with a StringIndexOutOfBounds exception.

	The patched file is attached, and I have separately emailed the original
authors.  The changes are minimal.  Basically, instead of using the string
length of the module (since there can now be many) to remove the 'File
ModuleName/' part at the start of each diff line (when parsing the rdiff
output), it just searches for the first index of '/', and substrings
everything from one character after that index.  I haven't tested this in a
Unix environment, so I don't know if the same slash is used, perhaps this
could be looked at by another?


		// get rid of 'File module/"
                line = line.substring(line.indexOf("/")+1);


	Cheers

		Rory Sinclair


This message is sent in confidence for the addressee only. It may 
contain legally privileged information. The contents are not to be 
disclosed shared or copied to anyone other than the addressee. 
Unauthorised recipients are requested to preserve this confidentiality 
and to advise the sender immediately of any error in transmission.
This mail has been scanned by DKAV anti-virus software.

RE: Tiny patch to CvsTagDiff.java

Posted by "Rory I. Sinclair" <ro...@levelfour.com>.
Ok I will do.  Thanks!

Rory

-----Original Message-----
From: Antoine Levy-Lambert [mailto:antoine@antbuild.com]
Sent: 07 July 2003 14:18
To: Ant Developers List
Subject: Re: Tiny patch to CvsTagDiff.java


Hi Rory, I cannot get hold of your attachment in your email.
Also, could you create a bug report in bugzilla with your patch attached to
it.
bugzilla is on http://nagoya.apache.org/bugzilla
Cheers
Antoine
----- Original Message -----
From: "Rory I. Sinclair" <ro...@levelfour.com>
Newsgroups: gmane.comp.jakarta.ant.devel
Sent: Monday, July 07, 2003 1:03 PM
Subject: Tiny patch to CvsTagDiff.java


> Hi
>
> Forgive a wet-behind-the-ears newbie here, this is my first contrib.
>
> I have made a tiny patch to CvsTagDiff.java to support multiple packages.
> CVS itself happily accepts a space-separated list of packages/files to
> perform the rdiff command upon, but the Ant task (at least in 1.5.3) fails
> with a StringIndexOutOfBounds exception.
>
> The patched file is attached, and I have separately emailed the original
> authors.  The changes are minimal.  Basically, instead of using the string
> length of the module (since there can now be many) to remove the 'File
> ModuleName/' part at the start of each diff line (when parsing the rdiff
> output), it just searches for the first index of '/', and substrings
> everything from one character after that index.  I haven't tested this in
a
> Unix environment, so I don't know if the same slash is used, perhaps this
> could be looked at by another?
>
>
> // get rid of 'File module/"
>                 line = line.substring(line.indexOf("/")+1);
>
>
> Cheers
>
> Rory Sinclair
>
>
> This message is sent in confidence for the addressee only. It may
> contain legally privileged information. The contents are not to be
> disclosed shared or copied to anyone other than the addressee.
> Unauthorised recipients are requested to preserve this confidentiality
> and to advise the sender immediately of any error in transmission.
> This mail has been scanned by DKAV anti-virus software.
>
>


----------------------------------------------------------------------------
----


> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org



This message is sent in confidence for the addressee only. It may 
contain legally privileged information. The contents are not to be 
disclosed shared or copied to anyone other than the addressee. 
Unauthorised recipients are requested to preserve this confidentiality 
and to advise the sender immediately of any error in transmission.
This mail has been scanned by DKAV anti-virus software.



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org

Re: Tiny patch to CvsTagDiff.java

Posted by Antoine Levy-Lambert <an...@antbuild.com>.
Hi Rory, I cannot get hold of your attachment in your email.
Also, could you create a bug report in bugzilla with your patch attached to
it.
bugzilla is on http://nagoya.apache.org/bugzilla
Cheers
Antoine
----- Original Message -----
From: "Rory I. Sinclair" <ro...@levelfour.com>
Newsgroups: gmane.comp.jakarta.ant.devel
Sent: Monday, July 07, 2003 1:03 PM
Subject: Tiny patch to CvsTagDiff.java


> Hi
>
> Forgive a wet-behind-the-ears newbie here, this is my first contrib.
>
> I have made a tiny patch to CvsTagDiff.java to support multiple packages.
> CVS itself happily accepts a space-separated list of packages/files to
> perform the rdiff command upon, but the Ant task (at least in 1.5.3) fails
> with a StringIndexOutOfBounds exception.
>
> The patched file is attached, and I have separately emailed the original
> authors.  The changes are minimal.  Basically, instead of using the string
> length of the module (since there can now be many) to remove the 'File
> ModuleName/' part at the start of each diff line (when parsing the rdiff
> output), it just searches for the first index of '/', and substrings
> everything from one character after that index.  I haven't tested this in
a
> Unix environment, so I don't know if the same slash is used, perhaps this
> could be looked at by another?
>
>
> // get rid of 'File module/"
>                 line = line.substring(line.indexOf("/")+1);
>
>
> Cheers
>
> Rory Sinclair
>
>
> This message is sent in confidence for the addressee only. It may
> contain legally privileged information. The contents are not to be
> disclosed shared or copied to anyone other than the addressee.
> Unauthorised recipients are requested to preserve this confidentiality
> and to advise the sender immediately of any error in transmission.
> This mail has been scanned by DKAV anti-virus software.
>
>


----------------------------------------------------------------------------
----


> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org