You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/05/01 15:10:47 UTC

[GitHub] rhtyd commented on a change in pull request #2593: api: move default response from XML to JSON

rhtyd commented on a change in pull request #2593: api: move default response from XML to JSON
URL: https://github.com/apache/cloudstack/pull/2593#discussion_r185244507
 
 

 ##########
 File path: server/src/main/java/com/cloud/api/ApiServlet.java
 ##########
 @@ -170,12 +170,6 @@ void processRequestInContext(final HttpServletRequest req, final HttpServletResp
 
         try {
 
-            if (HttpUtils.RESPONSE_TYPE_JSON.equalsIgnoreCase(responseType)) {
 
 Review comment:
   I think we should keep this, otherwise people won't be able to get XML output if a response type was provided.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services