You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/15 12:54:00 UTC
[jira] [Commented] (FLINK-8084) Remove japicmp deactivations in
several modules
[ https://issues.apache.org/jira/browse/FLINK-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253403#comment-16253403 ]
ASF GitHub Bot commented on FLINK-8084:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5020
[FLINK-8084][build] Remove unnecessary japicmp pom entries
## What is the purpose of the change
This PR removes unnecessary japicmp module entries from the java8, yarn-tests and quickstart pom. They were deactivating the plugin, even though it is deactivated by default.
## Verifying this change
Run `mvn clean package -B "-DskipTests" "-Dmaven.javadoc.skip=true" "-Dcheckstyle.skip=true"` in the affected modules and make sure the build passes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 8084
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5020.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5020
----
commit 84004f2616222eb8a9d954a1f5ac10fa33ebbf7c
Author: zentol <ch...@apache.org>
Date: 2017-11-15T12:51:01Z
[FLINK-8084][build] Remove unnecessary japicmp pom entries
----
> Remove japicmp deactivations in several modules
> -----------------------------------------------
>
> Key: FLINK-8084
> URL: https://issues.apache.org/jira/browse/FLINK-8084
> Project: Flink
> Issue Type: Improvement
> Components: Build System
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Trivial
>
> The japicmp module is explicitly deactivated in the following modules:
> * java8
> * quickstart
> * yarn-tests
> Since the module has to be explicitly enabled these entries can be removed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)