You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Vladimir Sitnikov <si...@gmail.com> on 2023/06/28 15:44:02 UTC
JMeter 5.6.1 release plan
Hi,
I suggest we release JMeter 5.6.1 soon as the latest 5.6 has several issues:
* ThreadGroups run forever in non-GUI mode if JMX is saved with 5.6 (fix
merged)
* Java samplers can't be re-enabled after disabling them (fix merged)
I included unicode filename encoding to 5.6, however, it was based on an
outdated RFC.
The current browsers use UTF-8 by default for encoding the data, and if the
filename can't be encoded, Chrome uses HTML entities.
I suggest we go for UTF-8 by default, since, well, the browsers do that,
and Java 18+ uses UTF-8 by default thanks to JEP 400.
The PR is https://github.com/apache/jmeter/pull/6010
Any thoughts?
The other improvements would be:
* Moving to Gradle JVM Toolchains, so we can use different JDKs for
building, testing, and executing Gradle (merged)
* CI testing with Java 21 (merged)
* bumping third-party patch versions (we can bump some patch versions from
https://github.com/apache/jmeter/issues/5823 )
Vladimir
Re: JMeter 5.6.1 release plan
Posted by Vladimir Sitnikov <si...@gmail.com>.
I think we are good to start with 5.6.1 RC1
Vladimir
Re: JMeter 5.6.1 release plan
Posted by Vladimir Sitnikov <si...@gmail.com>.
> So I can start RC1 for 5.6.1 today?
I've merged "utf-8 by default" PR, so the only thing left before preparing
a RC is
updating the changelog: https://github.com/apache/jmeter/pull/6024
If the changelog looks good to me, we can merge PR6024 and start RC1.
> (i think that we have an issue on release plugin about the no-generated
> .asc and .sha512 file on release files)
I fixed and merged it in https://github.com/apache/jmeter/pull/6003
Vladimir
Re: JMeter 5.6.1 release plan
Posted by Milamber <mi...@apache.org>.
Hi Vlad,
So I can start RC1 for 5.6.1 today?
(i think that we have an issue on release plugin about the no-generated
.asc and .sha512 file on release files)
Milamber
On 29/06/2023 08:57, Vladimir Sitnikov wrote:
>>> * improvement on JavaFX missing error message when java 9+?
> 1) The build now excludes JavaFX-based components unless you opt-in
> with -PenableJavaFx
> 2) I've reduced log severity: info + no stacktrace by default,
> debug+stacktrace if logging is in debug mode
>
> Vladimir
>
Re: JMeter 5.6.1 release plan
Posted by Vladimir Sitnikov <si...@gmail.com>.
>> * improvement on JavaFX missing error message when java 9+?
1) The build now excludes JavaFX-based components unless you opt-in
with -PenableJavaFx
2) I've reduced log severity: info + no stacktrace by default,
debug+stacktrace if logging is in debug mode
Vladimir
Re: JMeter 5.6.1 release plan
Posted by Milamber <mi...@apache.org>.
Thanks Philippe for notes, much clear now for me.
On 29/06/2023 08:25, Philippe Mouawad wrote:
> Hello,
> Few notes below
> Regards
>
> On Thu, Jun 29, 2023 at 9:19 AM Milamber <mi...@apache.org> wrote:
>
>> Hi,
>>
>> Can you confirm that these issues are included:
>>
>> * improvement on JavaFX missing error message when java 9+?
>> * fix for exception on http2 plugin
>>
> Vladimir explained the problem, it's more in the plugin code than in JMeter
>
>> * losing SampleResults on interruption
>>
> Although theorically I thought it would happen, I was not able to create
> a reproducer so not sure if it should be considered an issue
>
>> If yes, I can start a new RC.
>>
>> Milamber
>>
>> On 28/06/2023 16:44, Vladimir Sitnikov wrote:
>>> Hi,
>>>
>>> I suggest we release JMeter 5.6.1 soon as the latest 5.6 has several
>> issues:
>>> * ThreadGroups run forever in non-GUI mode if JMX is saved with 5.6 (fix
>>> merged)
>>> * Java samplers can't be re-enabled after disabling them (fix merged)
>>>
>>> I included unicode filename encoding to 5.6, however, it was based on an
>>> outdated RFC.
>>> The current browsers use UTF-8 by default for encoding the data, and if
>> the
>>> filename can't be encoded, Chrome uses HTML entities.
>>>
>>> I suggest we go for UTF-8 by default, since, well, the browsers do that,
>>> and Java 18+ uses UTF-8 by default thanks to JEP 400.
>>> The PR is https://github.com/apache/jmeter/pull/6010
>>>
>>> Any thoughts?
>>>
>>> The other improvements would be:
>>> * Moving to Gradle JVM Toolchains, so we can use different JDKs for
>>> building, testing, and executing Gradle (merged)
>>> * CI testing with Java 21 (merged)
>>> * bumping third-party patch versions (we can bump some patch versions
>> from
>>> https://github.com/apache/jmeter/issues/5823 )
>>>
>>> Vladimir
>>>
>>
Re: JMeter 5.6.1 release plan
Posted by Philippe Mouawad <ph...@gmail.com>.
Hello,
Few notes below
Regards
On Thu, Jun 29, 2023 at 9:19 AM Milamber <mi...@apache.org> wrote:
> Hi,
>
> Can you confirm that these issues are included:
>
> * improvement on JavaFX missing error message when java 9+?
> * fix for exception on http2 plugin
>
Vladimir explained the problem, it's more in the plugin code than in JMeter
> * losing SampleResults on interruption
>
Although theorically I thought it would happen, I was not able to create
a reproducer so not sure if it should be considered an issue
>
> If yes, I can start a new RC.
>
> Milamber
>
> On 28/06/2023 16:44, Vladimir Sitnikov wrote:
> > Hi,
> >
> > I suggest we release JMeter 5.6.1 soon as the latest 5.6 has several
> issues:
> > * ThreadGroups run forever in non-GUI mode if JMX is saved with 5.6 (fix
> > merged)
> > * Java samplers can't be re-enabled after disabling them (fix merged)
> >
> > I included unicode filename encoding to 5.6, however, it was based on an
> > outdated RFC.
> > The current browsers use UTF-8 by default for encoding the data, and if
> the
> > filename can't be encoded, Chrome uses HTML entities.
> >
> > I suggest we go for UTF-8 by default, since, well, the browsers do that,
> > and Java 18+ uses UTF-8 by default thanks to JEP 400.
> > The PR is https://github.com/apache/jmeter/pull/6010
> >
> > Any thoughts?
> >
> > The other improvements would be:
> > * Moving to Gradle JVM Toolchains, so we can use different JDKs for
> > building, testing, and executing Gradle (merged)
> > * CI testing with Java 21 (merged)
> > * bumping third-party patch versions (we can bump some patch versions
> from
> > https://github.com/apache/jmeter/issues/5823 )
> >
> > Vladimir
> >
>
>
--
Cordialement.
Philippe Mouawad.
Re: JMeter 5.6.1 release plan
Posted by Milamber <mi...@apache.org>.
Hi,
Can you confirm that these issues are included:
* improvement on JavaFX missing error message when java 9+?
* fix for exception on http2 plugin
* losing SampleResults on interruption
If yes, I can start a new RC.
Milamber
On 28/06/2023 16:44, Vladimir Sitnikov wrote:
> Hi,
>
> I suggest we release JMeter 5.6.1 soon as the latest 5.6 has several issues:
> * ThreadGroups run forever in non-GUI mode if JMX is saved with 5.6 (fix
> merged)
> * Java samplers can't be re-enabled after disabling them (fix merged)
>
> I included unicode filename encoding to 5.6, however, it was based on an
> outdated RFC.
> The current browsers use UTF-8 by default for encoding the data, and if the
> filename can't be encoded, Chrome uses HTML entities.
>
> I suggest we go for UTF-8 by default, since, well, the browsers do that,
> and Java 18+ uses UTF-8 by default thanks to JEP 400.
> The PR is https://github.com/apache/jmeter/pull/6010
>
> Any thoughts?
>
> The other improvements would be:
> * Moving to Gradle JVM Toolchains, so we can use different JDKs for
> building, testing, and executing Gradle (merged)
> * CI testing with Java 21 (merged)
> * bumping third-party patch versions (we can bump some patch versions from
> https://github.com/apache/jmeter/issues/5823 )
>
> Vladimir
>
Re: JMeter 5.6.1 release plan
Posted by Antonio Gomes Rodrigues <ra...@gmail.com>.
Hi,
Seems great to me
Le mer. 28 juin 2023 à 17:44, Vladimir Sitnikov <si...@gmail.com>
a écrit :
> Hi,
>
> I suggest we release JMeter 5.6.1 soon as the latest 5.6 has several
> issues:
> * ThreadGroups run forever in non-GUI mode if JMX is saved with 5.6 (fix
> merged)
> * Java samplers can't be re-enabled after disabling them (fix merged)
>
> I included unicode filename encoding to 5.6, however, it was based on an
> outdated RFC.
> The current browsers use UTF-8 by default for encoding the data, and if the
> filename can't be encoded, Chrome uses HTML entities.
>
> I suggest we go for UTF-8 by default, since, well, the browsers do that,
> and Java 18+ uses UTF-8 by default thanks to JEP 400.
> The PR is https://github.com/apache/jmeter/pull/6010
>
> Any thoughts?
>
> The other improvements would be:
> * Moving to Gradle JVM Toolchains, so we can use different JDKs for
> building, testing, and executing Gradle (merged)
> * CI testing with Java 21 (merged)
> * bumping third-party patch versions (we can bump some patch versions from
> https://github.com/apache/jmeter/issues/5823 )
>
> Vladimir
>