You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/04/03 07:01:55 UTC

[GitHub] [servicecomb-pack] WillemJiang commented on a change in pull request #446: fix mysql master_lock table schema wrong default value

WillemJiang commented on a change in pull request #446: fix mysql master_lock table schema wrong default value
URL: https://github.com/apache/servicecomb-pack/pull/446#discussion_r271601872
 
 

 ##########
 File path: alpha/alpha-server/src/main/resources/schema-mysql.sql
 ##########
 @@ -116,8 +116,8 @@ CREATE TABLE IF NOT EXISTS tcc_tx_event (
 
 CREATE TABLE IF NOT EXISTS master_lock (
   serviceName varchar(36) not NULL,
-  expireTime timestamp(3) not NULL,
-  lockedTime timestamp(3) not NULL,
+  expireTime datetime NOT NULL DEFAULT CURRENT_TIMESTAMP,
 
 Review comment:
   If there  is no side effect of using the CURRENT_TIMESTAMP ad the default value. We could just accept the PR.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services