You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by alsorokin <gi...@git.apache.org> on 2015/02/25 17:42:00 UTC
[GitHub] cordova-medic pull request: CB-8544 made iOS builder to wait for t...
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-medic/pull/34
CB-8544 made iOS builder to wait for tests to complete, refactored build...
https://issues.apache.org/jira/browse/CB-8544
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-medic CB-8544
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-medic/pull/34.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #34
----
commit fcf0c9e5b9053f38010cc9d3195a03f22ce25aaf
Author: alsorokin <al...@akvelon.com>
Date: 2015-02-25T16:13:22Z
CB-8544 made iOS builder to wait for tests to complete, refactored builder scripts
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-8544 made iOS builder to wait for t...
Posted by alsorokin <gi...@git.apache.org>.
Github user alsorokin commented on the pull request:
https://github.com/apache/cordova-medic/pull/34#issuecomment-76132189
Removed the try/catch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-8544 made iOS builder to wait for t...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/34#discussion_r25405334
--- Diff: src/utils/createMedicJson.js ---
@@ -0,0 +1,16 @@
+// /usr/bin/env node
+/*jshint node: true*/
+
+var fs = require('fs'),
+ path = require('path'),
+ error_writer = require('../build/makers/error_writer');
+
+module.exports = function createMedicJson(output, sha, cfg) {
+ try {
+ console.log('Writing medic.json to ' + output);
+ var medic_config = '{"sha":"' + sha + '","couchdb":"' + cfg.couchdb.host + '","couchdbext":"' + cfg.couchdb.exthost + '"}';
+ fs.writeFileSync(path.join(output, 'medic.json'), medic_config, 'utf-8');
+ } catch (e) {
--- End diff --
Why are we swallowing this exception and continuing - shouldn't we not continue if this step fails.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-8544 made iOS builder to wait for t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/34
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-8544 made iOS builder to wait for t...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-medic/pull/34#issuecomment-76127793
I agree, it's fatal.
Personally, I would not expect it to fail, and remove the try/catch completely.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org