You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "HubertKrawczyk (via GitHub)" <gi...@apache.org> on 2025/05/18 21:12:23 UTC
[PR] WIP: Einsum [systemds]
HubertKrawczyk opened a new pull request, #2265:
URL: https://github.com/apache/systemds/pull/2265
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Einsum, initial PR [systemds]
Posted by "HubertKrawczyk (via GitHub)" <gi...@apache.org>.
HubertKrawczyk commented on PR #2265:
URL: https://github.com/apache/systemds/pull/2265#issuecomment-3207145414
> Hi @HubertKrawczyk - could you please rebase this PR to main, unfortunately I'm getting lots of merge conflicts, and I would be afraid of corrupting existing or your code. Maybe the easiest would be to take your code and create a new PR without these cross-merge commits. Once the commit is prepared I will merge it in, but remove the einsum tests from our github workflow actions until the docker container is including the respective R package.
Hi @mboehm7 , sure - here is link to new MR: https://github.com/apache/systemds/pull/2312
I did rebase and removed the workflow tests step
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Einsum, initial PR [systemds]
Posted by "HubertKrawczyk (via GitHub)" <gi...@apache.org>.
HubertKrawczyk closed pull request #2265: Einsum, initial PR
URL: https://github.com/apache/systemds/pull/2265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Einsum, initial PR [systemds]
Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard commented on PR #2265:
URL: https://github.com/apache/systemds/pull/2265#issuecomment-3031897720
Okay, feel free to assume that we installed the einsum package, and we will add it to the image soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Einsum, initial PR [systemds]
Posted by "HubertKrawczyk (via GitHub)" <gi...@apache.org>.
HubertKrawczyk commented on PR #2265:
URL: https://github.com/apache/systemds/pull/2265#issuecomment-3029392618
> > ```
> > ERROR: R has ended irregularly
> > R Standard output :
> >
> > R Standard Error :
> > Error in library("einsum") : there is no package called ‘einsum’
> > Execution halted
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > @Baunsgaard Would it be possible to install the R einsum package on the build server?
>
> yes, but preferably no. Is the operation you want to import easy to write in R linear algebra?
For some easy operations such as matrix multiplications - yes, for more complex chains it can be hard to write, unreadable and easy to do mistakes. And finally there can be some special ones that cannot be solved using 2D matrix operations e.g. 'fx,fg,fz,xg,zx,zg->g' (test 11) (the first intermediate would be 3 dimensional matrix) so the only option would be 4 for loops:
```
for (g in 1:G) {
sum_val <- 0
for (f in 1:F) {
for (x in 1:X) {
for (z in 1:Z) {
sum_val <- sum_val +
fx[f, x] *
fg[f, g] *
fz[f, z] *
xg[x, g] *
zx[z, x] *
zg[z, g]
}
}
}
out[g] <- sum_val
}
```
so if we don't want the package then this can be solution, but I think it would be just more readable with a simple einsum call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Einsum, initial PR [systemds]
Posted by "mboehm7 (via GitHub)" <gi...@apache.org>.
mboehm7 commented on PR #2265:
URL: https://github.com/apache/systemds/pull/2265#issuecomment-3206516264
Hi @HubertKrawczyk - could you please rebase this PR to main, unfortunately I'm getting lots of merge conflicts, and I would be afraid of corrupting existing or your code. Maybe the easiest would be to take your code and create a new PR without these cross-merge commits. Once the commit is prepared I will merge it in, but remove the einsum tests from our github workflow actions until the docker container is including the respective R package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Einsum, initial PR [systemds]
Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard commented on PR #2265:
URL: https://github.com/apache/systemds/pull/2265#issuecomment-3026978462
> ```
> ERROR: R has ended irregularly
> R Standard output :
>
> R Standard Error :
> Error in library("einsum") : there is no package called ‘einsum’
> Execution halted
> ```
>
> @Baunsgaard Would it be possible to install the R einsum package on the build server?
yes, but preferably no. Is the operation you want to import easy to write in R linear algebra?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Einsum, initial PR [systemds]
Posted by "HubertKrawczyk (via GitHub)" <gi...@apache.org>.
HubertKrawczyk commented on PR #2265:
URL: https://github.com/apache/systemds/pull/2265#issuecomment-3019722396
```
ERROR: R has ended irregularly
R Standard output :
R Standard Error :
Error in library("einsum") : there is no package called ‘einsum’
Execution halted
```
@Baunsgaard Would it be possible to install the R einsum package on the build server?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org