You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/10/25 16:30:32 UTC
[GitHub] [dubbo-go] zouyx opened a new pull request #803: Fix: Consumer panic when restart provider
zouyx opened a new pull request #803:
URL: https://github.com/apache/dubbo-go/pull/803
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
* The reason as below :
When delete provider node will close getty_client and set getty_pool to nil.
https://github.com/apache/dubbo-go/blob/1268a960bc7bdcd9457edca29f498e0ca42d0072/remoting/exchange_client.go#L182
However ExchangeClient.init is false cause getty_pool will not re-init when re-request.
https://github.com/apache/dubbo-go/blob/1268a960bc7bdcd9457edca29f498e0ca42d0072/remoting/exchange_client.go#L61
So change a flag for re-init getty_pool
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #803: Fix: Consumer panic when restart provider
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #803:
URL: https://github.com/apache/dubbo-go/pull/803
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #803: Fix: Consumer panic when restart provider
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #803:
URL: https://github.com/apache/dubbo-go/pull/803#issuecomment-716175849
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/803?src=pr&el=h1) Report
> Merging [#803](https://codecov.io/gh/apache/dubbo-go/pull/803?src=pr&el=desc) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/272ddd598d036d1b85cf0a6279e7877549a48c32?el=desc) will **decrease** coverage by `4.16%`.
> The diff coverage is `52.18%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/803?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5 #803 +/- ##
==========================================
- Coverage 63.72% 59.56% -4.17%
==========================================
Files 237 258 +21
Lines 12295 12585 +290
==========================================
- Hits 7835 7496 -339
- Misses 3706 4142 +436
- Partials 754 947 +193
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/803?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/loadbalance/consistent\_hash.go](https://codecov.io/gh/apache/dubbo-go/pull/803/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9jb25zaXN0ZW50X2hhc2guZ28=) | `87.75% <ø> (-2.57%)` | :arrow_down: |
| [cluster/router/condition/listenable\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/803/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL2xpc3RlbmFibGVfcm91dGVyLmdv) | `54.71% <ø> (-0.13%)` | :arrow_down: |
| [cluster/router/tag/file.go](https://codecov.io/gh/apache/dubbo-go/pull/803/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL2ZpbGUuZ28=) | `76.19% <ø> (-0.74%)` | :arrow_down: |
| [common/extension/health\_checker.go](https://codecov.io/gh/apache/dubbo-go/pull/803/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9oZWFsdGhfY2hlY2tlci5nbw==) | `50.00% <ø> (-16.67%)` | :arrow_down: |
| [common/extension/metadata\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/803/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlLmdv) | `0.00% <0.00%> (ø)` | |
| [common/logger/logger.go](https://codecov.io/gh/apache/dubbo-go/pull/803/diff?src=pr&el=tree#diff-Y29tbW9uL2xvZ2dlci9sb2dnZXIuZ28=) | `91.37% <0.00%> (-3.86%)` | :arrow_down: |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/803/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.33% <0.00%> (-7.31%)` | :arrow_down: |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/803/diff?src=pr&el=tree#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `87.94% <ø> (+1.35%)` | :arrow_up: |
| [common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go/pull/803/diff?src=pr&el=tree#diff-Y29tbW9uL3lhbWwveWFtbC5nbw==) | `90.90% <0.00%> (-9.10%)` | :arrow_down: |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/803/diff?src=pr&el=tree#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `50.00% <0.00%> (-8.07%)` | :arrow_down: |
| ... and [346 more](https://codecov.io/gh/apache/dubbo-go/pull/803/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/803?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/803?src=pr&el=footer). Last update [1268a96...643a7c7](https://codecov.io/gh/apache/dubbo-go/pull/803?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] kedadiannao220 commented on pull request #803: Fix: Consumer panic when restart provider
Posted by GitBox <gi...@apache.org>.
kedadiannao220 commented on pull request #803:
URL: https://github.com/apache/dubbo-go/pull/803#issuecomment-717660156
测试成功
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org