[GitHub] [incubator-sdap-nexus] skorper commented on a change in pull request #132: SDAP-338: Update match up implementation to support multi-variable tiles

[GitBox <gi...@apache.org>]

skorper commented on a change in pull request #132:
URL: https://github.com/apache/incubator-sdap-nexus/pull/132#discussion_r709632309



##########
File path: data-access/nexustiles/model/nexusmodel.py
##########
@@ -100,6 +136,8 @@ def nexus_point_generator(self, include_nan=False):
     def get_indices(self, include_nan=False):
         if include_nan:
             return list(np.ndindex(self.data.shape))
+        if self.is_multi:
+            return np.argwhere(self.data[0])

Review comment:
       I'm beginning to doubt this after a comment by Vardis during the SDAP meeting today -- if it's possible each variable is masked differently we would need to get the mask separately per-variable. This would have major performance implications for swath datasets so I need to give this more thought. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org