You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "vamsikarnika (via GitHub)" <gi...@apache.org> on 2025/01/30 11:49:43 UTC
[PR] Implement FileId + RecordKey based sort partitioning to reduce skew i… [hudi]
vamsikarnika opened a new pull request, #12741:
URL: https://github.com/apache/hudi/pull/12741
…n the data
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2679734270
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3291",
"triggerID" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"triggerType" : "PUSH"
}, {
"hash" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3292",
"triggerID" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"triggerType" : "PUSH"
}, {
"hash" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3860",
"triggerID" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"triggerType" : "PUSH"
}, {
"hash" : "3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3861",
"triggerID" : "3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3861)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement FileId + RecordKey based sort partitioning to reduce skew i… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2624283697
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3291",
"triggerID" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 81853e099a907b1b8899a315bd4f3e1f4a691b43 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3291)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2684163385
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3903",
"triggerID" : "7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3903)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2683642383
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3291",
"triggerID" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"triggerType" : "PUSH"
}, {
"hash" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3292",
"triggerID" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"triggerType" : "PUSH"
}, {
"hash" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3860",
"triggerID" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"triggerType" : "PUSH"
}, {
"hash" : "3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3861",
"triggerID" : "3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7",
"triggerType" : "PUSH"
}, {
"hash" : "5a8ec1dd81354dd54ca311b3312b853db80698d0",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3899",
"triggerID" : "5a8ec1dd81354dd54ca311b3312b853db80698d0",
"triggerType" : "PUSH"
}, {
"hash" : "7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3903",
"triggerID" : "7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a8ec1dd81354dd54ca311b3312b853db80698d0 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3899)
* 7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3903)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2683960243
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #12741:
URL: https://github.com/apache/hudi/pull/12741#discussion_r1970737858
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java:
##########
@@ -620,6 +628,11 @@ public Builder bloomIndexBucketizedChecking(boolean bucketizedChecking) {
return this;
}
+ public Builder bloomIndexFileGroupIdKeySortPartitioner(boolean fileGroupIdKeySortPartitioner) {
+ hoodieIndexConfig.setValue(BLOOM_INDEX_FILE_GROUP_ID_KEY_SORT_PARTITIONER, String.valueOf(fileGroupIdKeySortPartitioner));
+ return this;
+ }
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2683811292
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2624437318
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3291",
"triggerID" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"triggerType" : "PUSH"
}, {
"hash" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3292",
"triggerID" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 81853e099a907b1b8899a315bd4f3e1f4a691b43 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3291)
* 666815b4f646bf58e2e30d700a82938d7ea6cb1e Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3292)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2679412456
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3291",
"triggerID" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"triggerType" : "PUSH"
}, {
"hash" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3292",
"triggerID" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"triggerType" : "PUSH"
}, {
"hash" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3860",
"triggerID" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 666815b4f646bf58e2e30d700a82938d7ea6cb1e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3292)
* ebfb115d57b2932467d657bf1ed97f18f2906f3a Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3860)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement FileId + RecordKey based sort partitioning to reduce skew i… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2624290428
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3291",
"triggerID" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"triggerType" : "PUSH"
}, {
"hash" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 81853e099a907b1b8899a315bd4f3e1f4a691b43 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3291)
* 666815b4f646bf58e2e30d700a82938d7ea6cb1e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2683765767
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3291",
"triggerID" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"triggerType" : "PUSH"
}, {
"hash" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3292",
"triggerID" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"triggerType" : "PUSH"
}, {
"hash" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3860",
"triggerID" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"triggerType" : "PUSH"
}, {
"hash" : "3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3861",
"triggerID" : "3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7",
"triggerType" : "PUSH"
}, {
"hash" : "5a8ec1dd81354dd54ca311b3312b853db80698d0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3899",
"triggerID" : "5a8ec1dd81354dd54ca311b3312b853db80698d0",
"triggerType" : "PUSH"
}, {
"hash" : "7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3903",
"triggerID" : "7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3903)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2679438173
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3291",
"triggerID" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"triggerType" : "PUSH"
}, {
"hash" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3292",
"triggerID" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"triggerType" : "PUSH"
}, {
"hash" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3860",
"triggerID" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"triggerType" : "PUSH"
}, {
"hash" : "3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 666815b4f646bf58e2e30d700a82938d7ea6cb1e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3292)
* ebfb115d57b2932467d657bf1ed97f18f2906f3a Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3860)
* 3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2679408671
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3291",
"triggerID" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"triggerType" : "PUSH"
}, {
"hash" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3292",
"triggerID" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"triggerType" : "PUSH"
}, {
"hash" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 666815b4f646bf58e2e30d700a82938d7ea6cb1e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3292)
* ebfb115d57b2932467d657bf1ed97f18f2906f3a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2679442051
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3291",
"triggerID" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"triggerType" : "PUSH"
}, {
"hash" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3292",
"triggerID" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"triggerType" : "PUSH"
}, {
"hash" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3860",
"triggerID" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"triggerType" : "PUSH"
}, {
"hash" : "3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ebfb115d57b2932467d657bf1ed97f18f2906f3a Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3860)
* 3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2683630968
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3291",
"triggerID" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"triggerType" : "PUSH"
}, {
"hash" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3292",
"triggerID" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"triggerType" : "PUSH"
}, {
"hash" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3860",
"triggerID" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"triggerType" : "PUSH"
}, {
"hash" : "3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3861",
"triggerID" : "3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7",
"triggerType" : "PUSH"
}, {
"hash" : "5a8ec1dd81354dd54ca311b3312b853db80698d0",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3899",
"triggerID" : "5a8ec1dd81354dd54ca311b3312b853db80698d0",
"triggerType" : "PUSH"
}, {
"hash" : "7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a8ec1dd81354dd54ca311b3312b853db80698d0 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3899)
* 7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #12741:
URL: https://github.com/apache/hudi/pull/12741#discussion_r1970719814
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java:
##########
@@ -147,6 +147,14 @@ public class HoodieIndexConfig extends HoodieConfig {
+ "When true, bucketized bloom filtering is enabled. "
+ "This reduces skew seen in sort based bloom index lookup");
+ public static final ConfigProperty<String> BLOOM_INDEX_FILE_GROUP_ID_KEY_SORT_PARTITIONER = ConfigProperty
+ .key("hoodie.bloom.index.fileId.key.sort.partitioner")
Review Comment:
```suggestion
.key("hoodie.bloom.index.fileid.key.sorting.enable")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement FileId + RecordKey based sort partitioning to reduce skew i… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2624280540
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 81853e099a907b1b8899a315bd4f3e1f4a691b43 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #12741:
URL: https://github.com/apache/hudi/pull/12741#discussion_r1970723394
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java:
##########
@@ -620,6 +628,11 @@ public Builder bloomIndexBucketizedChecking(boolean bucketizedChecking) {
return this;
}
+ public Builder bloomIndexFileGroupIdKeySortPartitioner(boolean fileGroupIdKeySortPartitioner) {
+ hoodieIndexConfig.setValue(BLOOM_INDEX_FILE_GROUP_ID_KEY_SORT_PARTITIONER, String.valueOf(fileGroupIdKeySortPartitioner));
+ return this;
+ }
Review Comment:
Rename method and variables accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #12741:
URL: https://github.com/apache/hudi/pull/12741#discussion_r1970737686
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java:
##########
@@ -147,6 +147,14 @@ public class HoodieIndexConfig extends HoodieConfig {
+ "When true, bucketized bloom filtering is enabled. "
+ "This reduces skew seen in sort based bloom index lookup");
+ public static final ConfigProperty<String> BLOOM_INDEX_FILE_GROUP_ID_KEY_SORT_PARTITIONER = ConfigProperty
+ .key("hoodie.bloom.index.fileId.key.sort.partitioner")
Review Comment:
Fixed.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java:
##########
@@ -147,6 +147,14 @@ public class HoodieIndexConfig extends HoodieConfig {
+ "When true, bucketized bloom filtering is enabled. "
+ "This reduces skew seen in sort based bloom index lookup");
+ public static final ConfigProperty<String> BLOOM_INDEX_FILE_GROUP_ID_KEY_SORT_PARTITIONER = ConfigProperty
+ .key("hoodie.bloom.index.fileId.key.sort.partitioner")
+ .defaultValue("false")
+ .markAdvanced()
Review Comment:
Fixed.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java:
##########
@@ -147,6 +147,14 @@ public class HoodieIndexConfig extends HoodieConfig {
+ "When true, bucketized bloom filtering is enabled. "
+ "This reduces skew seen in sort based bloom index lookup");
+ public static final ConfigProperty<String> BLOOM_INDEX_FILE_GROUP_ID_KEY_SORT_PARTITIONER = ConfigProperty
+ .key("hoodie.bloom.index.fileId.key.sort.partitioner")
+ .defaultValue("false")
+ .markAdvanced()
+ .withDocumentation("Only applies if index type is BLOOM. "
+ + "When true, fileId and key sort based partitioning is enabled "
+ + "This reduces skew seen in bucket based bloom index lookup");
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2683615464
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3291",
"triggerID" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"triggerType" : "PUSH"
}, {
"hash" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3292",
"triggerID" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"triggerType" : "PUSH"
}, {
"hash" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3860",
"triggerID" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"triggerType" : "PUSH"
}, {
"hash" : "3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3861",
"triggerID" : "3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7",
"triggerType" : "PUSH"
}, {
"hash" : "5a8ec1dd81354dd54ca311b3312b853db80698d0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3899",
"triggerID" : "5a8ec1dd81354dd54ca311b3312b853db80698d0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3861)
* 5a8ec1dd81354dd54ca311b3312b853db80698d0 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3899)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2683613425
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3291",
"triggerID" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"triggerType" : "PUSH"
}, {
"hash" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3292",
"triggerID" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"triggerType" : "PUSH"
}, {
"hash" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3860",
"triggerID" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"triggerType" : "PUSH"
}, {
"hash" : "3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3861",
"triggerID" : "3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7",
"triggerType" : "PUSH"
}, {
"hash" : "5a8ec1dd81354dd54ca311b3312b853db80698d0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5a8ec1dd81354dd54ca311b3312b853db80698d0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3861)
* 5a8ec1dd81354dd54ca311b3312b853db80698d0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2683628892
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3291",
"triggerID" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"triggerType" : "PUSH"
}, {
"hash" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3292",
"triggerID" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"triggerType" : "PUSH"
}, {
"hash" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3860",
"triggerID" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"triggerType" : "PUSH"
}, {
"hash" : "3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3861",
"triggerID" : "3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7",
"triggerType" : "PUSH"
}, {
"hash" : "5a8ec1dd81354dd54ca311b3312b853db80698d0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3899",
"triggerID" : "5a8ec1dd81354dd54ca311b3312b853db80698d0",
"triggerType" : "PUSH"
}, {
"hash" : "7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3861)
* 5a8ec1dd81354dd54ca311b3312b853db80698d0 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3899)
* 7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2683894753
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3903",
"triggerID" : "7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3903)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2683812914
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3903",
"triggerID" : "7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3903)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2679538063
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3291",
"triggerID" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"triggerType" : "PUSH"
}, {
"hash" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3292",
"triggerID" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"triggerType" : "PUSH"
}, {
"hash" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3860",
"triggerID" : "ebfb115d57b2932467d657bf1ed97f18f2906f3a",
"triggerType" : "PUSH"
}, {
"hash" : "3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3861",
"triggerID" : "3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ebfb115d57b2932467d657bf1ed97f18f2906f3a Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3860)
* 3a5e401a64cdcc67c7b19824ffc0a6f2ff8e92d7 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3861)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2683961978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3903",
"triggerID" : "7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7e35a62c2395d04612f5c7e0bbcaa4c6f2c39eba Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3903)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #12741:
URL: https://github.com/apache/hudi/pull/12741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #12741:
URL: https://github.com/apache/hudi/pull/12741#discussion_r1970719814
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java:
##########
@@ -147,6 +147,14 @@ public class HoodieIndexConfig extends HoodieConfig {
+ "When true, bucketized bloom filtering is enabled. "
+ "This reduces skew seen in sort based bloom index lookup");
+ public static final ConfigProperty<String> BLOOM_INDEX_FILE_GROUP_ID_KEY_SORT_PARTITIONER = ConfigProperty
+ .key("hoodie.bloom.index.fileId.key.sort.partitioner")
Review Comment:
```suggestion
.key("hoodie.bloom.index.fileid.key.sort.partitioner")
```
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java:
##########
@@ -147,6 +147,14 @@ public class HoodieIndexConfig extends HoodieConfig {
+ "When true, bucketized bloom filtering is enabled. "
+ "This reduces skew seen in sort based bloom index lookup");
+ public static final ConfigProperty<String> BLOOM_INDEX_FILE_GROUP_ID_KEY_SORT_PARTITIONER = ConfigProperty
+ .key("hoodie.bloom.index.fileId.key.sort.partitioner")
+ .defaultValue("false")
+ .markAdvanced()
+ .withDocumentation("Only applies if index type is BLOOM. "
+ + "When true, fileId and key sort based partitioning is enabled "
+ + "This reduces skew seen in bucket based bloom index lookup");
Review Comment:
```suggestion
.withDocumentation("Only applies if index type is BLOOM. "
+ "When true, the global sorting based on the fileId and key is enabled during key lookup. "
+ "This reduces skew in the key lookup in the bloom index.");
```
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java:
##########
@@ -147,6 +147,14 @@ public class HoodieIndexConfig extends HoodieConfig {
+ "When true, bucketized bloom filtering is enabled. "
+ "This reduces skew seen in sort based bloom index lookup");
+ public static final ConfigProperty<String> BLOOM_INDEX_FILE_GROUP_ID_KEY_SORT_PARTITIONER = ConfigProperty
+ .key("hoodie.bloom.index.fileId.key.sort.partitioner")
+ .defaultValue("false")
+ .markAdvanced()
Review Comment:
add `.sinceVersion`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2624649983
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3291",
"triggerID" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"triggerType" : "PUSH"
}, {
"hash" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3292",
"triggerID" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 666815b4f646bf58e2e30d700a82938d7ea6cb1e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3292)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-8940] Fix Bloom Index Partitioner to distribute keys uniformly across partitions [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12741:
URL: https://github.com/apache/hudi/pull/12741#issuecomment-2624295846
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3291",
"triggerID" : "81853e099a907b1b8899a315bd4f3e1f4a691b43",
"triggerType" : "PUSH"
}, {
"hash" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "666815b4f646bf58e2e30d700a82938d7ea6cb1e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 81853e099a907b1b8899a315bd4f3e1f4a691b43 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=3291)
* 666815b4f646bf58e2e30d700a82938d7ea6cb1e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org