You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2017/04/17 23:14:30 UTC
Review Request 58487: Fix allocation quantities when shared resources
are removed.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58487/
-----------------------------------------------------------
Review request for mesos, James Peach and Jiang Yan Xu.
Bugs: MESOS-7308
https://issues.apache.org/jira/browse/MESOS-7308
Repository: mesos
Description
-------
When shared resources are removed from the `allocations` in the sorter,
we remove the scalar quantity only when the shared resource is actually
removed (i.e. shared count goes down to 0). Similarly, we increase the
scalar quantity only when this is a new shared resource that is being
added to the `allocations`.
Diffs
-----
src/master/allocator/sorter/drf/sorter.cpp ed54680cecb637931fc344fbcf8fd3b14cc24295
Diff: https://reviews.apache.org/r/58487/diff/1/
Testing
-------
Tests passed.
Thanks,
Anindya Sinha
Re: Review Request 58487: Fix allocation quantities when shared
resources are removed.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58487/#review173369
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58485, 58486, 58487]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 28, 2017, 3:42 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58487/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 3:42 p.m.)
>
>
> Review request for mesos, James Peach and Jiang Yan Xu.
>
>
> Bugs: MESOS-7308
> https://issues.apache.org/jira/browse/MESOS-7308
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When shared resources are removed from the `allocations` in the sorter,
> we remove the scalar quantity only when the shared resource is actually
> removed (i.e. shared count goes down to 0). Similarly, we increase the
> scalar quantity only when this is a new shared resource that is being
> added to the `allocations`.
>
>
> Diffs
> -----
>
> src/master/allocator/sorter/drf/sorter.hpp fee58d6d1f08163e2a06a4a20c891fe535c3dcff
>
>
> Diff: https://reviews.apache.org/r/58487/diff/3/
>
>
> Testing
> -------
>
> Tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 58487: Fix allocation quantities when shared
resources are removed.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58487/
-----------------------------------------------------------
(Updated May 11, 2017, 6:13 p.m.)
Review request for mesos, James Peach and Jiang Yan Xu.
Bugs: MESOS-7308
https://issues.apache.org/jira/browse/MESOS-7308
Repository: mesos
Description
-------
When shared resources are removed from the `allocations` in the sorter,
we remove the scalar quantity only when the shared resource is actually
removed (i.e. shared count goes down to 0). Similarly, we increase the
scalar quantity only when this is a new shared resource that is being
added to the `allocations`.
Diffs
-----
src/master/allocator/sorter/drf/sorter.hpp fee58d6d1f08163e2a06a4a20c891fe535c3dcff
Diff: https://reviews.apache.org/r/58487/diff/3/
Testing
-------
Tests passed.
Thanks,
Anindya Sinha
Re: Review Request 58487: Fix allocation quantities when shared
resources are removed.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58487/
-----------------------------------------------------------
(Updated April 28, 2017, 3:42 p.m.)
Review request for mesos, James Peach and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-7308
https://issues.apache.org/jira/browse/MESOS-7308
Repository: mesos
Description
-------
When shared resources are removed from the `allocations` in the sorter,
we remove the scalar quantity only when the shared resource is actually
removed (i.e. shared count goes down to 0). Similarly, we increase the
scalar quantity only when this is a new shared resource that is being
added to the `allocations`.
Diffs (updated)
-----
src/master/allocator/sorter/drf/sorter.hpp fee58d6d1f08163e2a06a4a20c891fe535c3dcff
Diff: https://reviews.apache.org/r/58487/diff/3/
Changes: https://reviews.apache.org/r/58487/diff/2-3/
Testing
-------
Tests passed.
Thanks,
Anindya Sinha
Re: Review Request 58487: Fix allocation quantities when shared
resources are removed.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58487/#review172418
-----------------------------------------------------------
Do we need this?
The method
```
virtual void update(
const std::string& name,
const SlaveID& slaveId,
const Resources& oldAllocation,
const Resources& newAllocation);
```
is not supposed to change the quantities (and we have another patch for adding a CHECK). We ought to be able to just assert that `oldAllocation` and `newAllocation` have the same quantity and then do not modify `allocations[name].scalarQuantities` or `allocations[name].totals[resource.name()]` at all. This is basically what the other does?
- Jiang Yan Xu
On April 18, 2017, 7:50 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58487/
> -----------------------------------------------------------
>
> (Updated April 18, 2017, 7:50 p.m.)
>
>
> Review request for mesos, James Peach and Jiang Yan Xu.
>
>
> Bugs: MESOS-7308
> https://issues.apache.org/jira/browse/MESOS-7308
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When shared resources are removed from the `allocations` in the sorter,
> we remove the scalar quantity only when the shared resource is actually
> removed (i.e. shared count goes down to 0). Similarly, we increase the
> scalar quantity only when this is a new shared resource that is being
> added to the `allocations`.
>
>
> Diffs
> -----
>
> src/master/allocator/sorter/drf/sorter.cpp ed54680cecb637931fc344fbcf8fd3b14cc24295
>
>
> Diff: https://reviews.apache.org/r/58487/diff/2/
>
>
> Testing
> -------
>
> Tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 58487: Fix allocation quantities when shared
resources are removed.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58487/#review172375
-----------------------------------------------------------
The test failure seems to be unrelated to this chain. Trying to see if a re-run of tests is triggered?
- Anindya Sinha
On April 19, 2017, 2:50 a.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58487/
> -----------------------------------------------------------
>
> (Updated April 19, 2017, 2:50 a.m.)
>
>
> Review request for mesos, James Peach and Jiang Yan Xu.
>
>
> Bugs: MESOS-7308
> https://issues.apache.org/jira/browse/MESOS-7308
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When shared resources are removed from the `allocations` in the sorter,
> we remove the scalar quantity only when the shared resource is actually
> removed (i.e. shared count goes down to 0). Similarly, we increase the
> scalar quantity only when this is a new shared resource that is being
> added to the `allocations`.
>
>
> Diffs
> -----
>
> src/master/allocator/sorter/drf/sorter.cpp ed54680cecb637931fc344fbcf8fd3b14cc24295
>
>
> Diff: https://reviews.apache.org/r/58487/diff/2/
>
>
> Testing
> -------
>
> Tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 58487: Fix allocation quantities when shared
resources are removed.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58487/
-----------------------------------------------------------
(Updated April 19, 2017, 2:50 a.m.)
Review request for mesos, James Peach and Jiang Yan Xu.
Bugs: MESOS-7308
https://issues.apache.org/jira/browse/MESOS-7308
Repository: mesos
Description
-------
When shared resources are removed from the `allocations` in the sorter,
we remove the scalar quantity only when the shared resource is actually
removed (i.e. shared count goes down to 0). Similarly, we increase the
scalar quantity only when this is a new shared resource that is being
added to the `allocations`.
Diffs (updated)
-----
src/master/allocator/sorter/drf/sorter.cpp ed54680cecb637931fc344fbcf8fd3b14cc24295
Diff: https://reviews.apache.org/r/58487/diff/2/
Changes: https://reviews.apache.org/r/58487/diff/1-2/
Testing
-------
Tests passed.
Thanks,
Anindya Sinha
Re: Review Request 58487: Fix allocation quantities when shared
resources are removed.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58487/#review172162
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58485, 58486, 58487]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 17, 2017, 11:14 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58487/
> -----------------------------------------------------------
>
> (Updated April 17, 2017, 11:14 p.m.)
>
>
> Review request for mesos, James Peach and Jiang Yan Xu.
>
>
> Bugs: MESOS-7308
> https://issues.apache.org/jira/browse/MESOS-7308
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When shared resources are removed from the `allocations` in the sorter,
> we remove the scalar quantity only when the shared resource is actually
> removed (i.e. shared count goes down to 0). Similarly, we increase the
> scalar quantity only when this is a new shared resource that is being
> added to the `allocations`.
>
>
> Diffs
> -----
>
> src/master/allocator/sorter/drf/sorter.cpp ed54680cecb637931fc344fbcf8fd3b14cc24295
>
>
> Diff: https://reviews.apache.org/r/58487/diff/1/
>
>
> Testing
> -------
>
> Tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>