You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/19 10:31:40 UTC

[GitHub] [flink] aljoscha commented on pull request #13681: [FLINK-19672][connector-kafka] Merge connector-kafka-base and connector-kafka

aljoscha commented on pull request #13681:
URL: https://github.com/apache/flink/pull/13681#issuecomment-712008666


   LGTM! This looks very straightforward, only moves code around. The only thing I'd be skeptical about is moving the state classes but you managed to keep them in the same package, so that's fine.
   
   Also, I would move the deprecation to a separate commit, at least.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org