You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/10/08 13:39:20 UTC

[GitHub] wujimin commented on a change in pull request #936: [SCB-737]Avoid null point exception

wujimin commented on a change in pull request #936: [SCB-737]Avoid null point exception
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/936#discussion_r223366629
 
 

 ##########
 File path: providers/provider-pojo/src/main/java/org/apache/servicecomb/provider/pojo/schema/PojoProducers.java
 ##########
 @@ -63,6 +63,9 @@ protected void processProvider(String beanName, Object bean) {
     // aop后,新的实例的父类可能是原class,也可能只是个proxy,父类不是原class
     // 所以,需要先取出原class,再取标注
     Class<?> beanCls = BeanUtils.getImplClassFromBean(bean);
+    if(beanCls == null) {
 
 Review comment:
   if got null, maybe will cause to lost schema definition
   so need to print a warn log at least.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services