You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "hangc0276 (via GitHub)" <gi...@apache.org> on 2023/03/12 03:33:49 UTC
[GitHub] [bookkeeper] hangc0276 opened a new pull request, #3859: Fix NPE in BenchThroughputLatency
hangc0276 opened a new pull request, #3859:
URL: https://github.com/apache/bookkeeper/pull/3859
### Motivation
When I start up a standalone bookie and use the following command the test the bookie server performance `bin/benchmark writes`, it throws the following exception and the benchmark process is blocked.
```
2023-03-12T11:22:37,685 - INFO - [main:BenchThroughputLatency@376] - Calculating percentiles
2023-03-12T11:22:37,797 - INFO - [main:BenchThroughputLatency@397] - 0 completions in 60003 milliseconds: 0 ops/sec
2023-03-12T11:22:38,185 - INFO - [main:BenchThroughputLatency@416] - 99th percentile latency: NaN
2023-03-12T11:22:38,185 - INFO - [main:BenchThroughputLatency@417] - 95th percentile latency: NaN
Exception in thread "main" java.lang.NullPointerException
at org.apache.bookkeeper.benchmark.BenchThroughputLatency.close(BenchThroughputLatency.java:114)
at org.apache.bookkeeper.benchmark.BenchThroughputLatency.main(BenchThroughputLatency.java:419)
```
The root cause is that the benchmark creates ledgers with EnsembleSize = 3, writeQorumSize = 2, and ackQorumSize=2, but I only startup one bookie, so the ledger creation failed. However, when we close the benchmark process, it will use the LedgerHandle to close the ledger, but the LedgerHandle is null due to ledger creation failure.
https://github.com/apache/bookkeeper/blob/cd43c91addb252f139cc207fe10adbb9344f9590/bookkeeper-benchmark/src/main/java/org/apache/bookkeeper/benchmark/BenchThroughputLatency.java#L112-L117
### Modifications
Check whether the LedgerHandle is null before calling close method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] merlimat merged pull request #3859: Fix NPE in BenchThroughputLatency
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat merged PR #3859:
URL: https://github.com/apache/bookkeeper/pull/3859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] codecov-commenter commented on pull request #3859: Fix NPE in BenchThroughputLatency
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3859:
URL: https://github.com/apache/bookkeeper/pull/3859#issuecomment-1465085969
## [Codecov](https://codecov.io/gh/apache/bookkeeper/pull/3859?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3859](https://codecov.io/gh/apache/bookkeeper/pull/3859?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a767413) into [master](https://codecov.io/gh/apache/bookkeeper/commit/cd43c91addb252f139cc207fe10adbb9344f9590?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cd43c91) will **decrease** coverage by `23.16%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3859 +/- ##
=============================================
- Coverage 44.17% 21.01% -23.16%
+ Complexity 4384 2018 -2366
=============================================
Files 473 473
Lines 40982 40982
Branches 5241 5241
=============================================
- Hits 18102 8611 -9491
- Misses 20994 31106 +10112
+ Partials 1886 1265 -621
```
| Flag | Coverage Δ | |
|---|---|---|
| client | `?` | |
| tls | `21.01% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 264 files with indirect coverage changes](https://codecov.io/gh/apache/bookkeeper/pull/3859/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org