You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "leechor (GitHub)" <gi...@apache.org> on 2019/08/18 06:57:12 UTC
[GitHub] [dubbo] leechor opened pull request #4865: simplified code
## What is the purpose of the change
simplified code, not change the behaviour
## Brief changelog
- add @Override on invoke in the subclass of Invoker
- clearify Loadbalance weight calculate
- simplfiy instantiateForDeserialize method's logic
## Verifying this change
passed
[ Full content available at: https://github.com/apache/dubbo/pull/4865 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #4865: simplified code
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/4865?src=pr&el=h1) Report
> Merging [#4865](https://codecov.io/gh/apache/dubbo/pull/4865?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo/commit/171ed255a05ef82f47bc5bacd424019004e5bb49?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `95.65%`.
[](https://codecov.io/gh/apache/dubbo/pull/4865?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4865 +/- ##
============================================
+ Coverage 63.9% 63.92% +0.02%
- Complexity 449 450 +1
============================================
Files 769 769
Lines 33177 33160 -17
Branches 5229 5228 -1
============================================
- Hits 21201 21199 -2
+ Misses 9553 9538 -15
Partials 2423 2423
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/4865?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/dubbo/pull/4865/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkxvYWRlci5qYXZh) | `79.26% <ø> (+0.26%)` | `0 <0> (ø)` | :arrow_down: |
| [...o/rpc/cluster/loadbalance/AbstractLoadBalance.java](https://codecov.io/gh/apache/dubbo/pull/4865/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvbG9hZGJhbGFuY2UvQWJzdHJhY3RMb2FkQmFsYW5jZS5qYXZh) | `52.94% <100%> (+5.88%)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/common/beanutil/JavaBeanDescriptor.java](https://codecov.io/gh/apache/dubbo/pull/4865/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYmVhbnV0aWwvSmF2YUJlYW5EZXNjcmlwdG9yLmphdmE=) | `91.66% <100%> (+2.77%)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dubbo/common/beanutil/JavaBeanSerializeUtil.java](https://codecov.io/gh/apache/dubbo/pull/4865/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYmVhbnV0aWwvSmF2YUJlYW5TZXJpYWxpemVVdGlsLmphdmE=) | `80.79% <90%> (+1.48%)` | `0 <0> (ø)` | :arrow_down: |
| [.../apache/dubbo/qos/protocol/QosProtocolWrapper.java](https://codecov.io/gh/apache/dubbo/pull/4865/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb3RvY29sL1Fvc1Byb3RvY29sV3JhcHBlci5qYXZh) | `65.85% <0%> (-17.08%)` | `0% <0%> (ø)` | |
| [...ng/exchange/support/header/HeartbeatTimerTask.java](https://codecov.io/gh/apache/dubbo/pull/4865/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRUaW1lclRhc2suamF2YQ==) | `73.68% <0%> (-5.27%)` | `0% <0%> (ø)` | |
| [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/4865/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh) | `61.17% <0%> (-4.71%)` | `0% <0%> (ø)` | |
| [...c/main/java/org/apache/dubbo/rpc/RpcException.java](https://codecov.io/gh/apache/dubbo/pull/4865/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNFeGNlcHRpb24uamF2YQ==) | `80% <0%> (-3.34%)` | `0% <0%> (ø)` | |
| [.../rpc/protocol/dubbo/LazyConnectExchangeClient.java](https://codecov.io/gh/apache/dubbo/pull/4865/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0xhenlDb25uZWN0RXhjaGFuZ2VDbGllbnQuamF2YQ==) | `56.47% <0%> (-2.36%)` | `0% <0%> (ø)` | |
| [.../exchange/support/header/HeaderExchangeServer.java](https://codecov.io/gh/apache/dubbo/pull/4865/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZVNlcnZlci5qYXZh) | `65.09% <0%> (-1.89%)` | `0% <0%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/dubbo/pull/4865/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/4865?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/4865?src=pr&el=footer). Last update [171ed25...37e5004](https://codecov.io/gh/apache/dubbo/pull/4865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo/pull/4865 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] Moriadry commented on pull request #4865: simplified
code
Posted by "Moriadry (GitHub)" <gi...@apache.org>.
why would u change this method, It seems original method definition is cleaner.
[ Full content available at: https://github.com/apache/dubbo/pull/4865 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #4865: simplified code
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/4865?src=pr&el=h1) Report
> Merging [#4865](https://codecov.io/gh/apache/dubbo/pull/4865?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo/commit/171ed255a05ef82f47bc5bacd424019004e5bb49?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `94.11%`.
[](https://codecov.io/gh/apache/dubbo/pull/4865?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4865 +/- ##
============================================
- Coverage 63.97% 63.92% -0.06%
+ Complexity 452 451 -1
============================================
Files 769 769
Lines 33177 33160 -17
Branches 5229 5228 -1
============================================
- Hits 21226 21197 -29
- Misses 9530 9546 +16
+ Partials 2421 2417 -4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/4865?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/dubbo/pull/4865/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkxvYWRlci5qYXZh) | `79% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...o/rpc/cluster/loadbalance/AbstractLoadBalance.java](https://codecov.io/gh/apache/dubbo/pull/4865/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvbG9hZGJhbGFuY2UvQWJzdHJhY3RMb2FkQmFsYW5jZS5qYXZh) | `52.94% <100%> (+5.88%)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/common/beanutil/JavaBeanDescriptor.java](https://codecov.io/gh/apache/dubbo/pull/4865/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYmVhbnV0aWwvSmF2YUJlYW5EZXNjcmlwdG9yLmphdmE=) | `91.66% <100%> (+2.77%)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dubbo/common/beanutil/JavaBeanSerializeUtil.java](https://codecov.io/gh/apache/dubbo/pull/4865/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYmVhbnV0aWwvSmF2YUJlYW5TZXJpYWxpemVVdGlsLmphdmE=) | `80.79% <90%> (+1.48%)` | `0 <0> (ø)` | :arrow_down: |
| [.../apache/dubbo/qos/protocol/QosProtocolWrapper.java](https://codecov.io/gh/apache/dubbo/pull/4865/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb3RvY29sL1Fvc1Byb3RvY29sV3JhcHBlci5qYXZh) | `65.85% <0%> (-17.08%)` | `0% <0%> (ø)` | |
| [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/4865/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `61.9% <0%> (-9.53%)` | `0% <0%> (ø)` | |
| [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/4865/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `51.42% <0%> (-5.72%)` | `0% <0%> (ø)` | |
| [.../org/apache/dubbo/remoting/ExecutionException.java](https://codecov.io/gh/apache/dubbo/pull/4865/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9FeGVjdXRpb25FeGNlcHRpb24uamF2YQ==) | `15.78% <0%> (-5.27%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/dubbo/pull/4865/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `58.69% <0%> (-4.35%)` | `0% <0%> (ø)` | |
| [...exchange/support/header/HeaderExchangeHandler.java](https://codecov.io/gh/apache/dubbo/pull/4865/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZUhhbmRsZXIuamF2YQ==) | `64.75% <0%> (-2.46%)` | `0% <0%> (ø)` | |
| ... and [8 more](https://codecov.io/gh/apache/dubbo/pull/4865/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/4865?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/4865?src=pr&el=footer). Last update [171ed25...e52a5df](https://codecov.io/gh/apache/dubbo/pull/4865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo/pull/4865 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] Moriadry commented on pull request #4865: simplified
code
Posted by "Moriadry (GitHub)" <gi...@apache.org>.
Same here.
[ Full content available at: https://github.com/apache/dubbo/pull/4865 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] Moriadry commented on pull request #4865: simplified
code
Posted by "Moriadry (GitHub)" <gi...@apache.org>.
You'd better not use a variable named oldValue1.
[ Full content available at: https://github.com/apache/dubbo/pull/4865 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] Moriadry commented on pull request #4865: simplified
code
Posted by "Moriadry (GitHub)" <gi...@apache.org>.
Keep this comment as it be.
[ Full content available at: https://github.com/apache/dubbo/pull/4865 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] leechor commented on pull request #4865: simplified
code
Posted by "leechor (GitHub)" <gi...@apache.org>.
consider there is not other case used a different message, so extract to a common method. but maybe u are right.
[ Full content available at: https://github.com/apache/dubbo/pull/4865 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org