[jira] [Commented] (ORC-418) Fix broken centos6 compilation

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667701#comment-16667701 ] 

ASF GitHub Bot commented on ORC-418:
------------------------------------

omalley opened a new pull request #328: ORC-418. Fix broken docker builds.
URL: https://github.com/apache/orc/pull/328
 
 
   Ok this patch fixes a lot of the compatibility problems that have been added recently:
   
   - use of noexcept instead of ORC_NOEXCEPT
   - replace use of nullptr with ORC_NULLPTR
   - replace use of override with ORC_OVERRIDE
   - testing for problematic cases of std::to_string have incomplete type coverage
   - minor field initialization changes to make the older g++ happy
   - make all of the docker scripts install openjdk 8
   - the very old linux versions need an older version of protobuf to compile correctly
   - the old linux versions need an older version of snappy to compile correctly
   - modify the run-all.sh script to pass the correct options to cmake
   - fix some of the new tests to not depend on the default charset
   - fix one case where an old g++ didn't like initializing a vector with a literal

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix broken centos6 compilation
> ------------------------------
>
>                 Key: ORC-418
>                 URL: https://issues.apache.org/jira/browse/ORC-418
>             Project: ORC
>          Issue Type: Improvement
>          Components: C++
>    Affects Versions: 1.6.0
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>            Priority: Major
>
> We've accidentally broken the centos 6 C++ build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)