You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/03 17:50:39 UTC
[GitHub] [arrow] nealrichardson opened a new pull request #11079: ARROW-13820: [R] Rename na.min_count to min_count and na.rm to skip_nulls
nealrichardson opened a new pull request #11079:
URL: https://github.com/apache/arrow/pull/11079
Also contains ARROW-13821: [R] Handle na.rm in sd, var bindings
The only other place we take nonstandard C++ options in make_compute_options is for a few types (like count) where there is an enum that controls options and we switch off based on a boolean. We can try to clean that up but I'm inclined to wait to see if anyone needs lower-level control.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on a change in pull request #11079: ARROW-13820: [R] Rename na.min_count to min_count and na.rm to skip_nulls
Posted by GitBox <gi...@apache.org>.
ianmcook commented on a change in pull request #11079:
URL: https://github.com/apache/arrow/pull/11079#discussion_r704517649
##########
File path: r/R/compute.R
##########
@@ -120,15 +120,15 @@ max.ArrowDatum <- function(..., na.rm = FALSE) {
scalar_aggregate("min_max", ..., na.rm = na.rm)$GetFieldByName("max")
}
-scalar_aggregate <- function(FUN, ..., na.rm = FALSE, na.min_count = 0) {
+scalar_aggregate <- function(FUN, ..., na.rm = FALSE, min_count = 0) {
Review comment:
```suggestion
scalar_aggregate <- function(FUN, ..., na.rm = FALSE, min_count = 0L) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #11079: ARROW-13820: [R] Rename na.min_count to min_count and na.rm to skip_nulls
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #11079:
URL: https://github.com/apache/arrow/pull/11079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11079: ARROW-13820: [R] Rename na.min_count to min_count and na.rm to skip_nulls
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11079:
URL: https://github.com/apache/arrow/pull/11079#issuecomment-912707856
https://issues.apache.org/jira/browse/ARROW-13820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org