You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by grkvlt <gi...@git.apache.org> on 2014/10/28 13:29:35 UTC

[GitHub] incubator-brooklyn pull request: Fixes for Riak under Clocker

GitHub user grkvlt opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/276

    Fixes for Riak under Clocker

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/grkvlt/incubator-brooklyn riak-fixes-clocker

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/276.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #276
    
----
commit 07b35b38bdaeefcbd5692e60091aca17c9c65609
Author: Andrew Kennedy <gr...@apache.org>
Date:   2014-10-28T12:24:28Z

    Fixes for Riak under Clocker

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fixes for Riak under Clocker

Posted by ahgittin <gi...@git.apache.org>.

Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/276#issuecomment-60766128
  
    looks good.  testing now.  will report whether `SUBNET_HOSTNAME` is always populated or not.
    
    unrelated but weird failure, /cc @aledsage --
    
        java.lang.IllegalArgumentException: Could not find keystore: /home/jenkins/jenkins-slave/workspace/incubator-brooklyn-pull-requests%402/usage/launcher/target/test-classes/server.ks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fixes for Riak under Clocker

Posted by grkvlt <gi...@git.apache.org>.

Github user grkvlt commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/276#issuecomment-60792579
  
    Merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fixes for Riak under Clocker

Posted by ahgittin <gi...@git.apache.org>.

Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/276#issuecomment-60823517
  
    it appears in some cases SUBNET_HOSTNAME is not available (e.g. clocker without weave) and in this case the driver.subnetHostname reference in `vm.args` causes an exception to be thrown.
    
    can we change it so `driver.getSubnetHostname()` returns the primary hostname if there is no subnet hostname?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fixes for Riak under Clocker

Posted by ahgittin <gi...@git.apache.org>.

Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/276#issuecomment-60769175
  
    works in SL


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fixes for Riak under Clocker

Posted by ahgittin <gi...@git.apache.org>.

Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/276#discussion_r19474301
  
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/riak/RiakNodeSshDriver.java ---
    @@ -192,14 +195,14 @@ public void customize() {
             customizeScript.execute();
     
             //set the riak node name
    -        entity.setAttribute(RiakNode.RIAK_NODE_NAME, format("riak@%s", getHostname()));
    +        entity.setAttribute(RiakNode.RIAK_NODE_NAME, format("riak@%s", getEntity().getAttribute(Attributes.SUBNET_HOSTNAME)));
    --- End diff --
    
    is `SUBNET_HOSTNAME` always guaranteed to be populated?  suggest calling `getSubnetHostname()` and putting logic there to fallback to using `getHostname()` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fixes for Riak under Clocker

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/276


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---