You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2013/01/08 10:40:17 UTC
[Bug 54384] New: Improve a confusing log message related to
LimitRequestLine
https://issues.apache.org/bugzilla/show_bug.cgi?id=54384
Bug ID: 54384
Summary: Improve a confusing log message related to
LimitRequestLine
Product: Apache httpd-2
Version: 2.4.3
Hardware: PC
OS: Linux
Status: NEW
Severity: major
Priority: P2
Component: Core
Assignee: bugs@httpd.apache.org
Reporter: jackie.qq.zhang@gmail.com
Classification: Unclassified
Created attachment 29828
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29828&action=edit
An improved log message patch to make the diagnosis easier
Hi, all,
Is it possible to change the following log message to be more accurate and
explicit that links to the configuration directive? (see the patch attached)
"AH00565: request failed: URI too long (longer than xxxx)"
Currently, it's kind of confusing without reading the code. I even do not know
what the "URI" refers to when saw the log message: I didn't know whether it's a
problem on the server side or client side.
Having read the code, I know this's because and only because the client's HTTP
request-line exceeds the server's "LimitRequestLine" setting.
Compared with "LimitRequestLine", the log message of "LimitRequestFieldsize" is
very very clear:
"AH00561: Request header exceeds LimitRequestFieldSize"
Moreover, the current message is not acurrate because request-line also
consists of the HTTP method and protocol version besides URI.
I wonder whether we can have the same style of logging, which is implemented in
the patch.
Notice that the logging is at the place where "This is only going to happen if
it exceeds the configured limit for a request-line", so the patch is valid.
(You can search "HTTP_REQUEST_URI_TOO_LARGE" in the code to verify it)
Thanks,
Jackie
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 54384] Improve a confusing log message related to
LimitRequestLine
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54384
Graham Leggett <mi...@sharp.fm> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from Graham Leggett <mi...@sharp.fm> ---
Backported to v2.4.5.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 54384] Improve a confusing log message related to
LimitRequestLine
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54384
Christophe JAILLET <ch...@wanadoo.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |FixedInTrunk,
| |PatchAvailable
--- Comment #1 from Christophe JAILLET <ch...@wanadoo.fr> ---
Thank you for the report.
I agree with your analysis.
This has been applied to trunk.
http://svn.apache.org/viewvc?view=revision&sortby=date&revision=1433613
If nobody complains, I will propose for backport for 2.4.x in the coming days.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 54384] Improve a confusing log message related to
LimitRequestLine
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54384
Jackie Zhang <ja...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jackie.qq.zhang@gmail.com
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 54384] Improve a confusing log message related to
LimitRequestLine
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54384
Graham Leggett <mi...@sharp.fm> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #2 from Graham Leggett <mi...@sharp.fm> ---
Proposed for backport to v2.4.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org