You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Dmitri Tikhonov <dm...@netilla.com> on 2003/12/23 20:55:47 UTC
mod_proxy encodes tilde before issuing HTTP request.
ap_proxy_canonenc() encode tilde into hexadecimal format before issuing
HTTP request. This breaks some things for me. Why is it not allowed in
its original form? I modified the source (2.0.46) of proxy_util.c, and it
works fine.
- Dmitri.
--- proxy_util.c 2003/06/05 20:51:17 1.1.1.3
+++ proxy_util.c 2003/12/23 19:51:13 1.2
@@ -176,7 +176,7 @@
* it only permits ; / ? : @ = & as reserved chars.)
*/
if (t == enc_path)
- allowed = "$-_.+!*'(),;:@&=";
+ allowed = "~$-_.+!*'(),;:@&=";
else if (t == enc_search)
allowed = "$-_.!*'(),;:@&=";
else if (t == enc_user)
Re: mod_proxy encodes tilde before issuing HTTP request.
Posted by Graham Leggett <mi...@sharp.fm>.
Dmitri Tikhonov wrote:
> ap_proxy_canonenc() encode tilde into hexadecimal format before issuing
> HTTP request. This breaks some things for me. Why is it not allowed in
> its original form? I modified the source (2.0.46) of proxy_util.c, and it
> works fine.
>
> - Dmitri.
>
>
> --- proxy_util.c 2003/06/05 20:51:17 1.1.1.3
> +++ proxy_util.c 2003/12/23 19:51:13 1.2
> @@ -176,7 +176,7 @@
> * it only permits ; / ? : @ = & as reserved chars.)
> */
> if (t == enc_path)
> - allowed = "$-_.+!*'(),;:@&=";
> + allowed = "~$-_.+!*'(),;:@&=";
> else if (t == enc_search)
> allowed = "$-_.!*'(),;:@&=";
> else if (t == enc_user)
This seems logical to me - +1.
I would imagine this could also be applied to v1.3? Any objections?
Regards,
Graham
--