You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "stevenzwu (via GitHub)" <gi...@apache.org> on 2023/02/11 04:04:13 UTC
[GitHub] [iceberg] stevenzwu opened a new pull request, #6808: Flink: backport PR #6764 to 1.14 and 1.15 for elapsedSecondsSinceLast…
stevenzwu opened a new pull request, #6808:
URL: https://github.com/apache/iceberg/pull/6808
…SuccessfulCommit sink metric
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on pull request #6808: Flink: backport PR #6764 to 1.14 and 1.15 for elapsedSecondsSinceLast…
Posted by "stevenzwu (via GitHub)" <gi...@apache.org>.
stevenzwu commented on PR #6808:
URL: https://github.com/apache/iceberg/pull/6808#issuecomment-1433705057
thanks @hililiwei for reviewing. mergin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu merged pull request #6808: Flink: backport PR #6764 to 1.14 and 1.15 for elapsedSecondsSinceLast…
Posted by "stevenzwu (via GitHub)" <gi...@apache.org>.
stevenzwu merged PR #6808:
URL: https://github.com/apache/iceberg/pull/6808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on a diff in pull request #6808: Flink: backport PR #6764 to 1.14 and 1.15 for elapsedSecondsSinceLast…
Posted by "stevenzwu (via GitHub)" <gi...@apache.org>.
stevenzwu commented on code in PR #6808:
URL: https://github.com/apache/iceberg/pull/6808#discussion_r1103509255
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java:
##########
@@ -286,7 +287,7 @@ private void commitPendingResult(
}
continuousEmptyCheckpoints = 0;
} else {
- LOG.info("Skipping committing empty checkpoint {}", checkpointId);
Review Comment:
it seems that this log line was added in 1.15 only and wasn't ported to 1.14 or 1.16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org