[GitHub] [trafficserver] rob05c commented on a diff in pull request #8853: Change parent_select Init func to constructor

[GitBox <gi...@apache.org>]

rob05c commented on code in PR #8853:
URL: https://github.com/apache/trafficserver/pull/8853#discussion_r879932923


##########
plugins/experimental/parent_select/consistenthash.cc:
##########
@@ -106,19 +106,17 @@ PLNextHopConsistentHash::chashLookup(const std::shared_ptr<ATSConsistentHash> &r
   }
 }
 
-PLNextHopConsistentHash::PLNextHopConsistentHash(const std::string_view name) : PLNextHopSelectionStrategy(name) {}
-
 PLNextHopConsistentHash::~PLNextHopConsistentHash()
 {
   PL_NH_Debug(PL_NH_DEBUG_TAG, "destructor called for strategy named: %s", strategy_name.c_str());
 }
 
 #define PLUGIN_NAME "pparent_select"
 
-bool
-PLNextHopConsistentHash::Init(const YAML::Node &n)
+PLNextHopConsistentHash::PLNextHopConsistentHash(const std::string_view name, const YAML::Node &n)
+  : PLNextHopSelectionStrategy(name, n)
 {
-  TSDebug("pparent_select", "PLNextHopConsistentHash Init calling.");
+  TSDebug("pparent_select", "PLNextHopConsistentHash constructor calling.");

Review Comment:
   I agree. But since it'd make this require a re-review, easier to do in a separate PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org