You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/08/04 15:23:27 UTC

[GitHub] [storm] Ethanlm commented on pull request #3318: [STORM-3670] Separate configurations for daemon metric reporters and topology metrics reporters

Ethanlm commented on pull request #3318:
URL: https://github.com/apache/storm/pull/3318#issuecomment-668661705


   > From your research, do you have any insight as to why preparable reporters exist for Daemons vs the separate Worker settings?
   
   I believe their original intention is to make metricsV2 reporters work for daemons and workers.  `PreparableReporter` already exists before they implemented metricsV2. But I guess the work was not fully completed. And when I looked into this, I feel it is more clear to have separate configs for daemon vs worker,  regarding  readability, maintenance and usability.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org