You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2024/05/09 07:49:04 UTC
[PR] [improve][offlload] Replace usage of shaded class in OffsetsCache [pulsar]
lhotari opened a new pull request, #22683:
URL: https://github.com/apache/pulsar/pull/22683
### Motivation
When cherry-picking #22679 to branch-3.0, the build failed.
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project tiered-storage-jcloud: Compilation failure
[ERROR] /Users/lari/workspace-pulsar/pulsar-branch-3.0/tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/OffsetsCache.java:[23,53] package io.grpc.netty.shaded.io.netty.util.concurrent does not exist
```
I had made a mistake and used a shaded class in OffsetsCache
### Modifications
- replace with Guava's ThreadFactoryBuilder since Guava is already available in the tiered storage dependencies
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][offload] Replace usage of shaded class in OffsetsCache [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #22683:
URL: https://github.com/apache/pulsar/pull/22683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org