You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2015/07/12 06:44:42 UTC
Review Request 36428: Remove erroneous code for isolator modules.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36428/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Kapil Arya, and Timothy Chen.
Repository: mesos
Description
-------
Kapil: this appears to have been introduced in your commit 3a179ce2. Can you please verify this should be removed.
Diffs
-----
src/slave/containerizer/mesos/containerizer.cpp 47d146125dfd4ea909e7ec9d94f41cfa11d035e5
Diff: https://reviews.apache.org/r/36428/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 36428: Remove erroneous code for isolator modules.
Posted by Timothy Chen <tn...@apache.org>.
> On July 12, 2015, 5:16 a.m., Kapil Arya wrote:
> > It looks like it was introduced in f511395e instead (unless I am missing something here):
> >
> > https://github.com/apache/mesos/commit/f511395e#diff-c8ca6e064a8bf7b1b3c70e6525eabeceR129
That's what I'm seeing too. Do you still want to remove this? It seems like valid code unless we're able to auto-reorder volume mounts?
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36428/#review91402
-----------------------------------------------------------
On July 12, 2015, 4:44 a.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36428/
> -----------------------------------------------------------
>
> (Updated July 12, 2015, 4:44 a.m.)
>
>
> Review request for mesos, Ben Mahler, Kapil Arya, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Kapil: this appears to have been introduced in your commit 3a179ce2. Can you please verify this should be removed.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 47d146125dfd4ea909e7ec9d94f41cfa11d035e5
>
> Diff: https://reviews.apache.org/r/36428/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 36428: Remove erroneous code for isolator modules.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36428/#review91402
-----------------------------------------------------------
It looks like it was introduced in f511395e instead (unless I am missing something here):
https://github.com/apache/mesos/commit/f511395e#diff-c8ca6e064a8bf7b1b3c70e6525eabeceR129
- Kapil Arya
On July 12, 2015, 12:44 a.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36428/
> -----------------------------------------------------------
>
> (Updated July 12, 2015, 12:44 a.m.)
>
>
> Review request for mesos, Ben Mahler, Kapil Arya, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Kapil: this appears to have been introduced in your commit 3a179ce2. Can you please verify this should be removed.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 47d146125dfd4ea909e7ec9d94f41cfa11d035e5
>
> Diff: https://reviews.apache.org/r/36428/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 36428: Remove erroneous code for isolator modules.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36428/#review91403
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36428]
All tests passed.
- Mesos ReviewBot
On July 12, 2015, 4:44 a.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36428/
> -----------------------------------------------------------
>
> (Updated July 12, 2015, 4:44 a.m.)
>
>
> Review request for mesos, Ben Mahler, Kapil Arya, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Kapil: this appears to have been introduced in your commit 3a179ce2. Can you please verify this should be removed.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 47d146125dfd4ea909e7ec9d94f41cfa11d035e5
>
> Diff: https://reviews.apache.org/r/36428/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>