You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Daniel Vega Simoes <da...@corp.globo.com> on 2014/11/05 21:39:35 UTC
Review Request 27641: CLOUDSTACK-7849
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27641/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
There should be some kind of criteria to list the projects on the drop-down menu. We changed the projectSelect.js to sort the projects alphabetically.
JIRA - CLOUDSTACK-7849
https://issues.apache.org/jira/browse/CLOUDSTACK-7849
Diffs
-----
ui/scripts/ui-custom/projectSelect.js ba4c7c7
Diff: https://reviews.apache.org/r/27641/diff/
Testing
-------
Thanks,
Daniel Vega Simoes
Re: Review Request 27641: CLOUDSTACK-7849
Posted by Rajani Karuturi <ra...@apache.org>.
> On Nov. 6, 2014, 4:50 a.m., Rajani Karuturi wrote:
> > Can you also assign and resolve the JIRA ticket?
>
> Rajani Karuturi wrote:
> commit: e03a7e6feaae2d024f2a53afd71e0230309b1085 on 4.5 and master
putting the JIRA ID in commit message will also help.
- Rajani
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27641/#review60112
-----------------------------------------------------------
On Nov. 5, 2014, 8:39 p.m., Daniel Vega Simoes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27641/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 8:39 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> There should be some kind of criteria to list the projects on the drop-down menu. We changed the projectSelect.js to sort the projects alphabetically.
>
> JIRA - CLOUDSTACK-7849
> https://issues.apache.org/jira/browse/CLOUDSTACK-7849
>
>
> Diffs
> -----
>
> ui/scripts/ui-custom/projectSelect.js ba4c7c7
>
> Diff: https://reviews.apache.org/r/27641/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniel Vega Simoes
>
>
Re: Review Request 27641: CLOUDSTACK-7849
Posted by Rajani Karuturi <ra...@apache.org>.
> On Nov. 6, 2014, 4:50 a.m., Rajani Karuturi wrote:
> > Can you also assign and resolve the JIRA ticket?
commit: e03a7e6feaae2d024f2a53afd71e0230309b1085 on 4.5 and master
- Rajani
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27641/#review60112
-----------------------------------------------------------
On Nov. 5, 2014, 8:39 p.m., Daniel Vega Simoes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27641/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 8:39 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> There should be some kind of criteria to list the projects on the drop-down menu. We changed the projectSelect.js to sort the projects alphabetically.
>
> JIRA - CLOUDSTACK-7849
> https://issues.apache.org/jira/browse/CLOUDSTACK-7849
>
>
> Diffs
> -----
>
> ui/scripts/ui-custom/projectSelect.js ba4c7c7
>
> Diff: https://reviews.apache.org/r/27641/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniel Vega Simoes
>
>
Re: Review Request 27641: CLOUDSTACK-7849
Posted by Rajani Karuturi <ra...@apache.org>.
> On Nov. 6, 2014, 4:50 a.m., Rajani Karuturi wrote:
> > Can you also assign and resolve the JIRA ticket?
>
> Rajani Karuturi wrote:
> commit: e03a7e6feaae2d024f2a53afd71e0230309b1085 on 4.5 and master
>
> Rajani Karuturi wrote:
> putting the JIRA ID in commit message will also help.
>
> Daniel Vega Simoes wrote:
> Thanks Rajani. Will update the JIRA.
>
> Daniel Vega Simoes wrote:
> We did resolve the JIRA ticket, but were not able to change the assignee
Thanks. Can you also mark the review submitted?
- Rajani
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27641/#review60112
-----------------------------------------------------------
On Nov. 5, 2014, 8:39 p.m., Daniel Vega Simoes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27641/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 8:39 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> There should be some kind of criteria to list the projects on the drop-down menu. We changed the projectSelect.js to sort the projects alphabetically.
>
> JIRA - CLOUDSTACK-7849
> https://issues.apache.org/jira/browse/CLOUDSTACK-7849
>
>
> Diffs
> -----
>
> ui/scripts/ui-custom/projectSelect.js ba4c7c7
>
> Diff: https://reviews.apache.org/r/27641/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniel Vega Simoes
>
>
Re: Review Request 27641: CLOUDSTACK-7849
Posted by Daniel Vega Simoes <da...@corp.globo.com>.
> On Nov. 6, 2014, 4:50 a.m., Rajani Karuturi wrote:
> > Can you also assign and resolve the JIRA ticket?
>
> Rajani Karuturi wrote:
> commit: e03a7e6feaae2d024f2a53afd71e0230309b1085 on 4.5 and master
>
> Rajani Karuturi wrote:
> putting the JIRA ID in commit message will also help.
Thanks Rajani. Will update the JIRA.
- Daniel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27641/#review60112
-----------------------------------------------------------
On Nov. 5, 2014, 8:39 p.m., Daniel Vega Simoes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27641/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 8:39 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> There should be some kind of criteria to list the projects on the drop-down menu. We changed the projectSelect.js to sort the projects alphabetically.
>
> JIRA - CLOUDSTACK-7849
> https://issues.apache.org/jira/browse/CLOUDSTACK-7849
>
>
> Diffs
> -----
>
> ui/scripts/ui-custom/projectSelect.js ba4c7c7
>
> Diff: https://reviews.apache.org/r/27641/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniel Vega Simoes
>
>
Re: Review Request 27641: CLOUDSTACK-7849
Posted by Daniel Vega Simoes <da...@corp.globo.com>.
> On Nov. 6, 2014, 4:50 a.m., Rajani Karuturi wrote:
> > Can you also assign and resolve the JIRA ticket?
>
> Rajani Karuturi wrote:
> commit: e03a7e6feaae2d024f2a53afd71e0230309b1085 on 4.5 and master
>
> Rajani Karuturi wrote:
> putting the JIRA ID in commit message will also help.
>
> Daniel Vega Simoes wrote:
> Thanks Rajani. Will update the JIRA.
We did resolve the JIRA ticket, but were not able to change the assignee
- Daniel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27641/#review60112
-----------------------------------------------------------
On Nov. 5, 2014, 8:39 p.m., Daniel Vega Simoes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27641/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 8:39 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> There should be some kind of criteria to list the projects on the drop-down menu. We changed the projectSelect.js to sort the projects alphabetically.
>
> JIRA - CLOUDSTACK-7849
> https://issues.apache.org/jira/browse/CLOUDSTACK-7849
>
>
> Diffs
> -----
>
> ui/scripts/ui-custom/projectSelect.js ba4c7c7
>
> Diff: https://reviews.apache.org/r/27641/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniel Vega Simoes
>
>
Re: Review Request 27641: CLOUDSTACK-7849
Posted by Rajani Karuturi <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27641/#review60112
-----------------------------------------------------------
Ship it!
Can you also assign and resolve the JIRA ticket?
- Rajani Karuturi
On Nov. 5, 2014, 8:39 p.m., Daniel Vega Simoes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27641/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 8:39 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> There should be some kind of criteria to list the projects on the drop-down menu. We changed the projectSelect.js to sort the projects alphabetically.
>
> JIRA - CLOUDSTACK-7849
> https://issues.apache.org/jira/browse/CLOUDSTACK-7849
>
>
> Diffs
> -----
>
> ui/scripts/ui-custom/projectSelect.js ba4c7c7
>
> Diff: https://reviews.apache.org/r/27641/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniel Vega Simoes
>
>