You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/01/08 23:07:26 UTC
[GitHub] zeppelin pull request #1874: [ZEPPELIN-1914] Preserve spaces, newlines in te...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1874
[ZEPPELIN-1914] Preserve spaces, newlines in text output (BUG)
### What is this PR for?
Fixed to preserve spaces, newlines in text output.
### What type of PR is it?
[Bug Fix]
### Todos
* [x] - Refactored `result.controll.js`
* [x] - Removed the unused html file `result-results.html`
* [x] - Preserved spaces, newlines
### What is the Jira issue?
[ZEPPELIN-1914](https://issues.apache.org/jira/browse/ZEPPELIN-1914)
### How should this be tested?
1. Build Zeppelin with Spark 2.0, SparkR
2. Run Zeppelin with Spark 2.0+
3. Make sure that your `spark` interpreter can use `spark.r`
4. Execute this paragraph
```
%sparkrr
mtcarsDF <- createDataFrame(mtcars)
model <- glm(vs ~ mpg + disp + hp + wt , data = mtcarsDF, family = "binomial")
summary(model)
```
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-1914/respect-spaces-in-TEXT-output
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1874.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1874
----
commit a9d9409123f60605eb997a5f72dd56f25cad9848
Author: 1ambda <1a...@gmail.com>
Date: 2017-01-08T11:17:51Z
style: Remove useless newlines in R related files
commit a9db95243f8d0f67f4f1af7ffd36f16e6e1f6b09
Author: 1ambda <1a...@gmail.com>
Date: 2017-01-08T22:29:43Z
refactor: Use 1 funcs to get textElem
commit 8a3c051d9fbdc9edb1aaa1c9e03c4af35412c304
Author: 1ambda <1a...@gmail.com>
Date: 2017-01-08T22:30:26Z
chore: Remove unused file
commit 4c2aa127a97a829558d29fb6bb384eb7db7d9c99
Author: 1ambda <1a...@gmail.com>
Date: 2017-01-08T22:58:51Z
fix: Respect whitespaces in TEXT result
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1874: [ZEPPELIN-1914] Preserve spaces, newlines in te...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1874
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1874: [ZEPPELIN-1914] Preserve spaces, newlines in text outp...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1874
LGTM and merge to master if no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---