You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2019/10/16 08:36:14 UTC

[GitHub] [zeppelin] prabhjyotsingh commented on a change in pull request #3487: ZEPPELIN-4376, ZEPPELIN-4379 Zeppelin Web Vue - Design as per Mocks and Recycle Bin

prabhjyotsingh commented on a change in pull request #3487: ZEPPELIN-4376, ZEPPELIN-4379 Zeppelin Web Vue - Design as per Mocks and Recycle Bin
URL: https://github.com/apache/zeppelin/pull/3487#discussion_r335343388
 
 

 ##########
 File path: zeppelin-web-vue/src/components/Notebook/Controls.vue
 ##########
 @@ -52,52 +56,73 @@
       <a
         href="javascript: void(0);"
         @click="showDeleteConfirm"
+        v-if="!isDeleted"
       >
         <a-tooltip placement="top">
           <template slot="title">
-            <span>Delete</span>
+            <span>Move to Recycle Bin</span>
 
 Review comment:
   `Recycle Bin` is very windows specific, should we call it trash?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services