You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Matthias Wessendorf <ma...@apache.org> on 2008/11/14 10:12:51 UTC

TRINIDAD-992 (was Re: [VOTE] Release of Trinidad 1.0.10)

corrected the subject, since the vote isn't the right place for this.

On Fri, Nov 14, 2008 at 10:07 AM, Paul Mander <pa...@gmail.com> wrote:
>
> +1
> Just because this product needs to keep moving. How do bugs get fixed in
> Trinidad? I raised a bug, supplied a fix and got people to vote on it and
> yet it is stuck on unresolved since March April time.
>
> https://issues.apache.org/jira/browse/TRINIDAD-992

I don't see a patch there

>
> There's always fixes for file upload but if you look at them, nobody voted
> for them... In fact, looking at all the fixes in this build, no body voted
> for any of them. It appears that the contributors are simply fixing bugs
> that they have found.

it is new to me, that we need a vote on every fix. However, we take
bug serious and fix them. Providing a patch to the jira (not the mailing list,
or a private blog, etc) helps.

Please go ahead and update the bug.
Once that is done, I will re-evaluate the fix.

generally, once you uploaded a patch, please ping the dev list,
so folks get a heads up.

Thanks!
Matthias

>
> We use trinidad on a number of projects and have some horrific work arounds
> to get basic stuff working...
>
>
> Gerhard Petracek wrote:
>>
>> +1
>>
>> 2008/11/14 Manfred Geiler <ma...@gmail.com>
>>
>>> +1
>>>
>>> On Fri, Nov 14, 2008 at 9:15 AM, Thomas Spiegl <th...@gmail.com>
>>> wrote:
>>> > +1
>>> >
>>> > On Thu, Nov 13, 2008 at 7:06 PM, Grant Smith <wo...@gmail.com>
>>> wrote:
>>> >> +1
>>> >>
>>> >> On Thu, Nov 13, 2008 at 7:40 AM, <wo...@pta.de> wrote:
>>> >>>
>>> >>> +1
>>> >>>
>>> >>> ..no noticeable negative side effects :)
>>> >>>
>>> >>> Best wishes
>>> >>> Wolfgang
>>> >>>
>>> >>>
>>> >>>
>>> >>> "Matthias Wessendorf" <ma...@apache.org>
>>> >>> Gesendet von: mwessendorf@gmail.com
>>> >>>
>>> >>> 13.11.2008 09:19
>>> >>>
>>> >>> Bitte antworten an
>>> >>> "MyFaces Development" <de...@myfaces.apache.org>
>>> >>> An
>>> >>> "MyFaces Development" <de...@myfaces.apache.org>
>>> >>> Kopie
>>> >>> Thema
>>> >>> [VOTE] Release of Trinidad 1.0.10
>>> >>>
>>> >>>
>>> >>>
>>> >>>
>>> >>> Hi,
>>> >>>
>>> >>> I was running the needed tasks to get the 1.0.10 release of the
>>> Apache
>>> >>> MyFaces Trinidad CORE out. The artifacts are deployed to my private
>>> >>> Apache account ([1]).
>>> >>>
>>> >>> Please take a look at the "1.0.10" artifacts and vote
>>> >>>
>>> >>> ------------------------------------------------
>>> >>> [ ] +1 for community members who have reviewed the bits
>>> >>> [ ] +0
>>> >>> [ ] -1 for fatal flaws that should cause these bits not to be
>>> released,
>>> >>> and why..............
>>> >>> ------------------------------------------------
>>> >>>
>>> >>> Thanks,
>>> >>> Matthias
>>> >>>
>>> >>> [1]
>>> http://people.apache.org/~matzew/trinidad1010/<http://people.apache.org/%7Ematzew/trinidad1010/>
>>> >>>
>>> >>> --
>>> >>> Matthias Wessendorf
>>> >>>
>>> >>> blog: http://matthiaswessendorf.wordpress.com/
>>> >>> sessions: http://www.slideshare.net/mwessendorf
>>> >>> twitter: http://twitter.com/mwessendorf
>>> >>>
>>> >>
>>> >>
>>> >>
>>> >> --
>>> >> Grant Smith
>>> >>
>>> >>
>>> >
>>>
>>
>>
>>
>> --
>>
>> http://www.irian.at
>>
>> Your JSF powerhouse -
>> JSF Consulting, Development and
>> Courses in English and German
>>
>> Professional Support for Apache MyFaces
>>
>>
>
> --
> View this message in context: http://www.nabble.com/-VOTE--Release-of-Trinidad-1.0.10-tp20476472p20497014.html
> Sent from the My Faces - Dev mailing list archive at Nabble.com.
>
>



-- 
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

Re: TRINIDAD-992 (was Re: [VOTE] Release of Trinidad 1.0.10)

Posted by Paul Mander <pa...@gmail.com>.
IE6 and 7 for this one but not firefox.

The fix solves this problem but if the message layout was better then it
would never occur. The message gets added to the cell of the input field and
the layout of the label/input field means that when you have a message, to
show it moves the label.

e.g.

no message
 -------------------
| label    |inputfield |
 -------------------

with a message

 -------------------
|           |inputfield |
| label    |---------|
|           | message |
 -------------------

The ie probleem is that setting the message to null does not remove that
bottom cell. If the layout for the label and input component were as follows
then it would be less of an issue

 -------------------
| label    |inputfield |
 -------------------
|           |message  |
 -------------------





Matthias Wessendorf-4 wrote:
> 
> On Fri, Nov 14, 2008 at 10:12 AM, Matthias Wessendorf <ma...@apache.org>
> wrote:
>> corrected the subject, since the vote isn't the right place for this.
>>
>> On Fri, Nov 14, 2008 at 10:07 AM, Paul Mander <pa...@gmail.com>
>> wrote:
>>>
>>> +1
>>> Just because this product needs to keep moving. How do bugs get fixed in
>>> Trinidad? I raised a bug, supplied a fix and got people to vote on it
>>> and
>>> yet it is stuck on unresolved since March April time.
>>>
>>> https://issues.apache.org/jira/browse/TRINIDAD-992
>>
>> I don't see a patch there
> 
> check :-)
> 
> it was hidden in the comments:
> if (msgElem)
>       msgElem.innerHTML = "";
> 
> A better check would be
> 
> if (msgElem && messageElem.innerHTML !="")
>       msgElem.innerHTML = "";
> 
> 
> So, q for you.
> Only IE6 or IE7 or IE generally ?
> 
> Thanks!
> 
>>
>>>
>>> There's always fixes for file upload but if you look at them, nobody
>>> voted
>>> for them... In fact, looking at all the fixes in this build, no body
>>> voted
>>> for any of them. It appears that the contributors are simply fixing bugs
>>> that they have found.
>>
>> it is new to me, that we need a vote on every fix. However, we take
>> bug serious and fix them. Providing a patch to the jira (not the mailing
>> list,
>> or a private blog, etc) helps.
>>
>> Please go ahead and update the bug.
>> Once that is done, I will re-evaluate the fix.
>>
>> generally, once you uploaded a patch, please ping the dev list,
>> so folks get a heads up.
>>
>> Thanks!
>> Matthias
>>
>>>
>>> We use trinidad on a number of projects and have some horrific work
>>> arounds
>>> to get basic stuff working...
>>>
>>>
>>> Gerhard Petracek wrote:
>>>>
>>>> +1
>>>>
>>>> 2008/11/14 Manfred Geiler <ma...@gmail.com>
>>>>
>>>>> +1
>>>>>
>>>>> On Fri, Nov 14, 2008 at 9:15 AM, Thomas Spiegl
>>>>> <th...@gmail.com>
>>>>> wrote:
>>>>> > +1
>>>>> >
>>>>> > On Thu, Nov 13, 2008 at 7:06 PM, Grant Smith <wo...@gmail.com>
>>>>> wrote:
>>>>> >> +1
>>>>> >>
>>>>> >> On Thu, Nov 13, 2008 at 7:40 AM, <wo...@pta.de> wrote:
>>>>> >>>
>>>>> >>> +1
>>>>> >>>
>>>>> >>> ..no noticeable negative side effects :)
>>>>> >>>
>>>>> >>> Best wishes
>>>>> >>> Wolfgang
>>>>> >>>
>>>>> >>>
>>>>> >>>
>>>>> >>> "Matthias Wessendorf" <ma...@apache.org>
>>>>> >>> Gesendet von: mwessendorf@gmail.com
>>>>> >>>
>>>>> >>> 13.11.2008 09:19
>>>>> >>>
>>>>> >>> Bitte antworten an
>>>>> >>> "MyFaces Development" <de...@myfaces.apache.org>
>>>>> >>> An
>>>>> >>> "MyFaces Development" <de...@myfaces.apache.org>
>>>>> >>> Kopie
>>>>> >>> Thema
>>>>> >>> [VOTE] Release of Trinidad 1.0.10
>>>>> >>>
>>>>> >>>
>>>>> >>>
>>>>> >>>
>>>>> >>> Hi,
>>>>> >>>
>>>>> >>> I was running the needed tasks to get the 1.0.10 release of the
>>>>> Apache
>>>>> >>> MyFaces Trinidad CORE out. The artifacts are deployed to my
>>>>> private
>>>>> >>> Apache account ([1]).
>>>>> >>>
>>>>> >>> Please take a look at the "1.0.10" artifacts and vote
>>>>> >>>
>>>>> >>> ------------------------------------------------
>>>>> >>> [ ] +1 for community members who have reviewed the bits
>>>>> >>> [ ] +0
>>>>> >>> [ ] -1 for fatal flaws that should cause these bits not to be
>>>>> released,
>>>>> >>> and why..............
>>>>> >>> ------------------------------------------------
>>>>> >>>
>>>>> >>> Thanks,
>>>>> >>> Matthias
>>>>> >>>
>>>>> >>> [1]
>>>>> http://people.apache.org/~matzew/trinidad1010/<http://people.apache.org/%7Ematzew/trinidad1010/>
>>>>> >>>
>>>>> >>> --
>>>>> >>> Matthias Wessendorf
>>>>> >>>
>>>>> >>> blog: http://matthiaswessendorf.wordpress.com/
>>>>> >>> sessions: http://www.slideshare.net/mwessendorf
>>>>> >>> twitter: http://twitter.com/mwessendorf
>>>>> >>>
>>>>> >>
>>>>> >>
>>>>> >>
>>>>> >> --
>>>>> >> Grant Smith
>>>>> >>
>>>>> >>
>>>>> >
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> http://www.irian.at
>>>>
>>>> Your JSF powerhouse -
>>>> JSF Consulting, Development and
>>>> Courses in English and German
>>>>
>>>> Professional Support for Apache MyFaces
>>>>
>>>>
>>>
>>> --
>>> View this message in context:
>>> http://www.nabble.com/-VOTE--Release-of-Trinidad-1.0.10-tp20476472p20497014.html
>>> Sent from the My Faces - Dev mailing list archive at Nabble.com.
>>>
>>>
>>
>>
>>
>> --
>> Matthias Wessendorf
>>
>> blog: http://matthiaswessendorf.wordpress.com/
>> sessions: http://www.slideshare.net/mwessendorf
>> twitter: http://twitter.com/mwessendorf
>>
> 
> 
> 
> -- 
> Matthias Wessendorf
> 
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
> 
> 

-- 
View this message in context: http://www.nabble.com/TRINIDAD-992-%28was-Re%3A--VOTE--Release-of-Trinidad-1.0.10%29-tp20497081p20497478.html
Sent from the My Faces - Dev mailing list archive at Nabble.com.


Re: TRINIDAD-992 (was Re: [VOTE] Release of Trinidad 1.0.10)

Posted by Matthias Wessendorf <ma...@apache.org>.
On Fri, Nov 14, 2008 at 10:12 AM, Matthias Wessendorf <ma...@apache.org> wrote:
> corrected the subject, since the vote isn't the right place for this.
>
> On Fri, Nov 14, 2008 at 10:07 AM, Paul Mander <pa...@gmail.com> wrote:
>>
>> +1
>> Just because this product needs to keep moving. How do bugs get fixed in
>> Trinidad? I raised a bug, supplied a fix and got people to vote on it and
>> yet it is stuck on unresolved since March April time.
>>
>> https://issues.apache.org/jira/browse/TRINIDAD-992
>
> I don't see a patch there

check :-)

it was hidden in the comments:
if (msgElem)
      msgElem.innerHTML = "";

A better check would be

if (msgElem && messageElem.innerHTML !="")
      msgElem.innerHTML = "";


So, q for you.
Only IE6 or IE7 or IE generally ?

Thanks!

>
>>
>> There's always fixes for file upload but if you look at them, nobody voted
>> for them... In fact, looking at all the fixes in this build, no body voted
>> for any of them. It appears that the contributors are simply fixing bugs
>> that they have found.
>
> it is new to me, that we need a vote on every fix. However, we take
> bug serious and fix them. Providing a patch to the jira (not the mailing list,
> or a private blog, etc) helps.
>
> Please go ahead and update the bug.
> Once that is done, I will re-evaluate the fix.
>
> generally, once you uploaded a patch, please ping the dev list,
> so folks get a heads up.
>
> Thanks!
> Matthias
>
>>
>> We use trinidad on a number of projects and have some horrific work arounds
>> to get basic stuff working...
>>
>>
>> Gerhard Petracek wrote:
>>>
>>> +1
>>>
>>> 2008/11/14 Manfred Geiler <ma...@gmail.com>
>>>
>>>> +1
>>>>
>>>> On Fri, Nov 14, 2008 at 9:15 AM, Thomas Spiegl <th...@gmail.com>
>>>> wrote:
>>>> > +1
>>>> >
>>>> > On Thu, Nov 13, 2008 at 7:06 PM, Grant Smith <wo...@gmail.com>
>>>> wrote:
>>>> >> +1
>>>> >>
>>>> >> On Thu, Nov 13, 2008 at 7:40 AM, <wo...@pta.de> wrote:
>>>> >>>
>>>> >>> +1
>>>> >>>
>>>> >>> ..no noticeable negative side effects :)
>>>> >>>
>>>> >>> Best wishes
>>>> >>> Wolfgang
>>>> >>>
>>>> >>>
>>>> >>>
>>>> >>> "Matthias Wessendorf" <ma...@apache.org>
>>>> >>> Gesendet von: mwessendorf@gmail.com
>>>> >>>
>>>> >>> 13.11.2008 09:19
>>>> >>>
>>>> >>> Bitte antworten an
>>>> >>> "MyFaces Development" <de...@myfaces.apache.org>
>>>> >>> An
>>>> >>> "MyFaces Development" <de...@myfaces.apache.org>
>>>> >>> Kopie
>>>> >>> Thema
>>>> >>> [VOTE] Release of Trinidad 1.0.10
>>>> >>>
>>>> >>>
>>>> >>>
>>>> >>>
>>>> >>> Hi,
>>>> >>>
>>>> >>> I was running the needed tasks to get the 1.0.10 release of the
>>>> Apache
>>>> >>> MyFaces Trinidad CORE out. The artifacts are deployed to my private
>>>> >>> Apache account ([1]).
>>>> >>>
>>>> >>> Please take a look at the "1.0.10" artifacts and vote
>>>> >>>
>>>> >>> ------------------------------------------------
>>>> >>> [ ] +1 for community members who have reviewed the bits
>>>> >>> [ ] +0
>>>> >>> [ ] -1 for fatal flaws that should cause these bits not to be
>>>> released,
>>>> >>> and why..............
>>>> >>> ------------------------------------------------
>>>> >>>
>>>> >>> Thanks,
>>>> >>> Matthias
>>>> >>>
>>>> >>> [1]
>>>> http://people.apache.org/~matzew/trinidad1010/<http://people.apache.org/%7Ematzew/trinidad1010/>
>>>> >>>
>>>> >>> --
>>>> >>> Matthias Wessendorf
>>>> >>>
>>>> >>> blog: http://matthiaswessendorf.wordpress.com/
>>>> >>> sessions: http://www.slideshare.net/mwessendorf
>>>> >>> twitter: http://twitter.com/mwessendorf
>>>> >>>
>>>> >>
>>>> >>
>>>> >>
>>>> >> --
>>>> >> Grant Smith
>>>> >>
>>>> >>
>>>> >
>>>>
>>>
>>>
>>>
>>> --
>>>
>>> http://www.irian.at
>>>
>>> Your JSF powerhouse -
>>> JSF Consulting, Development and
>>> Courses in English and German
>>>
>>> Professional Support for Apache MyFaces
>>>
>>>
>>
>> --
>> View this message in context: http://www.nabble.com/-VOTE--Release-of-Trinidad-1.0.10-tp20476472p20497014.html
>> Sent from the My Faces - Dev mailing list archive at Nabble.com.
>>
>>
>
>
>
> --
> Matthias Wessendorf
>
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
>



-- 
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf