You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/10 00:25:44 UTC

[GitHub] [pulsar] rdhabalia opened a new pull request #12704: [pulsar-client] Fix pending queue-size stats for batch messages

rdhabalia opened a new pull request #12704:
URL: https://github.com/apache/pulsar/pull/12704


   ### Motivation
   Right now, pulsar-client prints stats with incorrect pending queue size for the batch messages. if the user configures batch-message size 100 (or batch delay is 10ms) and publishes 1000 messages then the producer prints stats with  < 10 pending messages instead 1000 messages which is published by user. It confuses the user because the user sees a different counter than actual published messages. it creates confusion when the user gets ProducerQueueFull Error and stats prints queue size is 10 and allowed pending-messages are 1000.
   
   ### Modification
   Show correct pending messages for batch messages.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet commented on pull request #12704: [pulsar-client] Fix pending queue-size stats for batch messages

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #12704:
URL: https://github.com/apache/pulsar/pull/12704#issuecomment-964951711


   @rdhabalia thanks. when submitting a PR, can you help provide a doc label (tick the box)? Thanks
   ![image](https://user-images.githubusercontent.com/50226895/141089372-4349e108-4971-40ad-b5ef-a640a82a1bbd.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] github-actions[bot] commented on pull request #12704: [pulsar-client] Fix pending queue-size stats for batch messages

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12704:
URL: https://github.com/apache/pulsar/pull/12704#issuecomment-964666015






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet commented on pull request #12704: [pulsar-client] Fix pending queue-size stats for batch messages

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #12704:
URL: https://github.com/apache/pulsar/pull/12704#issuecomment-964724420


   @rdhabalia seems that this is a bug fix and does not affect the user guide, so no need to update docs [here](https://pulsar.apache.org/docs/en/next/reference-cli-tools/#pulsar-client)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] rdhabalia commented on pull request #12704: [pulsar-client] Fix pending queue-size stats for batch messages

Posted by GitBox <gi...@apache.org>.
rdhabalia commented on pull request #12704:
URL: https://github.com/apache/pulsar/pull/12704#issuecomment-964748258


   @Anonymitaet it won't require doc change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] rdhabalia merged pull request #12704: [pulsar-client] Fix pending queue-size stats for batch messages

Posted by GitBox <gi...@apache.org>.
rdhabalia merged pull request #12704:
URL: https://github.com/apache/pulsar/pull/12704


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org